Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](binlog) Binlog ts not initialized #47174

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[fix](binlog) Binlog ts not initialized #47174

merged 1 commit into from
Jan 21, 2025

Conversation

wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Jan 17, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

selectdb/ccr-syncer#395

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32256 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c31274522fb82d356d29cc63527cb96065b876e9, data reload: false

------ Round 1 ----------------------------------
q1	17598	5486	5414	5414
q2	2049	312	176	176
q3	10404	1221	739	739
q4	10198	973	520	520
q5	7542	2378	2173	2173
q6	191	164	129	129
q7	880	749	612	612
q8	9235	1336	1127	1127
q9	5254	4837	4900	4837
q10	6915	2356	1901	1901
q11	499	279	253	253
q12	340	365	216	216
q13	17834	3679	3120	3120
q14	224	222	209	209
q15	512	480	464	464
q16	621	614	586	586
q17	553	851	318	318
q18	6782	6435	6450	6435
q19	1653	943	515	515
q20	319	320	188	188
q21	2945	2214	2012	2012
q22	368	338	312	312
Total cold run time: 102916 ms
Total hot run time: 32256 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5514	5503	5484	5484
q2	239	331	244	244
q3	2252	2566	2313	2313
q4	1414	1815	1345	1345
q5	4340	4754	4651	4651
q6	167	163	124	124
q7	2044	1925	1823	1823
q8	2637	2824	2759	2759
q9	7377	7259	7285	7259
q10	3037	3271	2810	2810
q11	577	527	505	505
q12	650	749	607	607
q13	3519	4037	3286	3286
q14	289	317	281	281
q15	499	485	475	475
q16	641	698	666	666
q17	1209	1725	1266	1266
q18	7663	7504	7290	7290
q19	804	1044	1137	1044
q20	1995	2099	1923	1923
q21	5773	5222	4935	4935
q22	604	631	597	597
Total cold run time: 53244 ms
Total hot run time: 51687 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194408 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c31274522fb82d356d29cc63527cb96065b876e9, data reload: false

query1	1305	962	917	917
query2	6455	2117	2052	2052
query3	10940	4499	4479	4479
query4	60022	31985	23447	23447
query5	5247	628	456	456
query6	414	186	169	169
query7	5554	504	291	291
query8	313	235	213	213
query9	8325	2562	2565	2562
query10	434	313	254	254
query11	16013	15209	15526	15209
query12	169	111	110	110
query13	1407	545	446	446
query14	11030	7344	6589	6589
query15	228	215	191	191
query16	7340	620	478	478
query17	1177	758	592	592
query18	1821	437	321	321
query19	214	212	148	148
query20	116	114	112	112
query21	216	128	105	105
query22	4297	4683	4584	4584
query23	33765	33335	33472	33335
query24	5622	2268	2376	2268
query25	486	463	388	388
query26	708	273	169	169
query27	1801	482	326	326
query28	3966	2445	2399	2399
query29	545	551	425	425
query30	223	187	183	183
query31	925	868	850	850
query32	70	60	63	60
query33	447	357	309	309
query34	736	883	492	492
query35	814	896	751	751
query36	996	1045	966	966
query37	119	109	78	78
query38	4259	4297	4337	4297
query39	1501	1459	1448	1448
query40	205	117	109	109
query41	51	50	51	50
query42	120	104	103	103
query43	533	533	476	476
query44	1325	802	820	802
query45	188	172	171	171
query46	891	1086	646	646
query47	1956	1935	1846	1846
query48	385	401	323	323
query49	729	483	398	398
query50	642	679	410	410
query51	7014	7042	6976	6976
query52	104	96	91	91
query53	238	258	184	184
query54	482	501	414	414
query55	88	85	87	85
query56	258	273	238	238
query57	1232	1247	1125	1125
query58	238	217	230	217
query59	2985	3089	2910	2910
query60	280	264	259	259
query61	115	114	110	110
query62	704	706	666	666
query63	221	190	185	185
query64	1703	1037	668	668
query65	3225	3146	3142	3142
query66	712	389	293	293
query67	16019	15685	15749	15685
query68	5097	830	523	523
query69	498	327	259	259
query70	1163	1109	1133	1109
query71	411	288	254	254
query72	5355	3834	3839	3834
query73	794	750	348	348
query74	10040	9269	9039	9039
query75	3174	3174	2681	2681
query76	3811	1152	763	763
query77	476	366	266	266
query78	10205	9936	9392	9392
query79	3408	744	587	587
query80	1711	548	421	421
query81	578	271	236	236
query82	360	160	125	125
query83	270	171	146	146
query84	290	105	76	76
query85	770	421	295	295
query86	460	319	299	299
query87	4541	4465	4361	4361
query88	4554	2159	2119	2119
query89	395	327	295	295
query90	1628	190	192	190
query91	133	136	108	108
query92	72	56	54	54
query93	2859	853	524	524
query94	748	410	306	306
query95	329	268	255	255
query96	498	604	274	274
query97	2805	2933	2764	2764
query98	230	211	189	189
query99	1274	1368	1265	1265
Total cold run time: 311600 ms
Total hot run time: 194408 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c31274522fb82d356d29cc63527cb96065b876e9, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.43	0.41	0.41
query6	1.14	0.65	0.64
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.49	0.50
query10	0.55	0.56	0.55
query11	0.14	0.09	0.10
query12	0.14	0.12	0.11
query13	0.60	0.60	0.60
query14	2.86	2.87	2.68
query15	0.88	0.82	0.83
query16	0.39	0.39	0.38
query17	1.03	0.98	1.01
query18	0.24	0.21	0.20
query19	1.89	1.82	2.00
query20	0.02	0.01	0.02
query21	15.36	0.94	0.58
query22	0.76	0.81	0.69
query23	15.28	1.43	0.60
query24	3.28	0.90	1.46
query25	0.16	0.31	0.06
query26	0.26	0.14	0.16
query27	0.03	0.05	0.07
query28	14.03	0.99	0.43
query29	12.63	3.99	3.31
query30	0.25	0.09	0.07
query31	2.84	0.58	0.38
query32	3.23	0.56	0.47
query33	3.11	2.98	3.01
query34	16.60	5.12	4.51
query35	4.58	4.47	4.47
query36	0.65	0.48	0.50
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.03	0.02
query40	0.17	0.13	0.13
query41	0.07	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.45 s
Total hot run time: 30.49 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 55702a1 into apache:master Jan 21, 2025
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 21, 2025
@wyxxxcat
[fix](binlog) Binlog ts not initialized (#47174)
96582b1 
selectdb/ccr-syncer#395
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jan 22, 2025
@github-actions @wyxxxcat
branch-3.0: [fix](binlog) Binlog ts not initialized #47174 (#47298)
db0d489 
Cherry-picked from #47174

Co-authored-by: Uniqueyou <[email protected]>
@wyxxxcat wyxxxcat mentioned this pull request Feb 19, 2025
Merged
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@wyxxxcat @lzyy2024
[fix](binlog) Binlog ts not initialized (apache#47174)
6b724c6 
selectdb/ccr-syncer#395
dataroaring pushed a commit that referenced this pull request Feb 21, 2025
@wyxxxcat
branch-2.1: [fix](binlog) Binlog ts not initialized #47174 (#48067)
514d419 
pick: #47174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w41ter w41ter w41ter approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wyxxxcat @Thearas @doris-robot @w41ter @dataroaring