Skip to content

branch-3.0: [fix](iceberg) Fix the failure of creating a table in OBS #49983 #50018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #49983

### What problem does this PR solve?

Problem Summary:

When use JDK17 with obs, if drop an iceberg table, an error will occur:
```
Caused by: java.lang.IllegalAccessException: class com.obs.services.internal.xml.OBSXMLBuilder cannot access class com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl (in module java.xml) because module java.xml does not export com.sun.org.apache.xerces.internal.jaxp to unnamed module @50ad3bc1
```

so, we should add JVM config: --add-opens
java.xml/com.sun.org.apache.xerces.internal.jaxp=ALL-UNNAMED
@github-actions github-actions bot requested a review from dataroaring as a code owner April 14, 2025 05:34
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 14, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39991 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b4fa6bb30c4fc279471f0b588d98ba6c3a845a14, data reload: false

------ Round 1 ----------------------------------
q1	17577	6736	6626	6626
q2	2068	169	160	160
q3	10651	1057	1149	1057
q4	10577	708	702	702
q5	7737	2893	2841	2841
q6	217	137	135	135
q7	975	628	602	602
q8	9360	1961	2012	1961
q9	6611	6399	6428	6399
q10	7018	2260	2303	2260
q11	461	267	257	257
q12	395	215	217	215
q13	18067	2998	2939	2939
q14	233	204	208	204
q15	502	459	460	459
q16	647	594	570	570
q17	963	520	570	520
q18	7115	6687	6765	6687
q19	1411	1079	1081	1079
q20	453	206	194	194
q21	4319	3169	3203	3169
q22	1111	989	955	955
Total cold run time: 108468 ms
Total hot run time: 39991 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6633	6548	6525	6525
q2	332	236	235	235
q3	2880	2750	2906	2750
q4	2023	1812	1814	1812
q5	5731	5756	5687	5687
q6	218	130	133	130
q7	2184	1812	1784	1784
q8	3348	3559	3502	3502
q9	8785	8864	8817	8817
q10	3560	3549	3482	3482
q11	599	505	488	488
q12	801	604	614	604
q13	9734	3235	3190	3190
q14	285	268	271	268
q15	519	464	458	458
q16	693	642	675	642
q17	1832	1621	1599	1599
q18	8325	7751	7709	7709
q19	1645	1561	1558	1558
q20	2118	1879	1867	1867
q21	5498	5349	5291	5291
q22	1131	1022	1013	1013
Total cold run time: 68874 ms
Total hot run time: 59411 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197077 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b4fa6bb30c4fc279471f0b588d98ba6c3a845a14, data reload: false

query1	1294	919	882	882
query2	6242	2022	1998	1998
query3	10794	4267	4283	4267
query4	61177	28453	23553	23553
query5	5077	459	447	447
query6	392	171	172	171
query7	5371	326	307	307
query8	289	215	220	215
query9	8148	2635	2602	2602
query10	451	288	259	259
query11	17097	15165	15620	15165
query12	165	102	102	102
query13	1378	472	435	435
query14	10047	6999	7837	6999
query15	197	189	179	179
query16	7143	467	493	467
query17	1156	549	571	549
query18	1779	341	321	321
query19	209	164	151	151
query20	115	109	109	109
query21	200	101	104	101
query22	4736	4431	4593	4431
query23	34782	34317	34176	34176
query24	6169	2992	2879	2879
query25	539	432	435	432
query26	655	180	177	177
query27	1780	376	364	364
query28	4309	2493	2440	2440
query29	710	478	477	477
query30	255	167	170	167
query31	962	835	862	835
query32	70	61	60	60
query33	452	315	305	305
query34	918	506	533	506
query35	843	754	736	736
query36	1095	971	970	970
query37	121	73	67	67
query38	4078	3935	3943	3935
query39	1528	1466	1487	1466
query40	203	103	106	103
query41	54	52	50	50
query42	119	103	105	103
query43	543	486	485	485
query44	1206	831	805	805
query45	188	175	170	170
query46	1157	730	739	730
query47	2013	1891	1874	1874
query48	485	389	382	382
query49	736	420	410	410
query50	869	460	428	428
query51	7373	7119	7223	7119
query52	106	97	91	91
query53	279	201	194	194
query54	653	501	481	481
query55	79	81	75	75
query56	273	250	239	239
query57	1260	1143	1097	1097
query58	218	210	210	210
query59	3030	2827	2902	2827
query60	295	263	276	263
query61	108	107	130	107
query62	811	676	644	644
query63	230	193	190	190
query64	1917	694	647	647
query65	3277	3204	3168	3168
query66	720	296	303	296
query67	15956	15666	15474	15474
query68	3227	599	598	598
query69	444	274	276	274
query70	1155	1044	1054	1044
query71	402	268	261	261
query72	6419	4224	3995	3995
query73	753	366	358	358
query74	10276	9210	9145	9145
query75	3360	2608	2677	2608
query76	2091	1150	1101	1101
query77	592	267	276	267
query78	10676	9642	9600	9600
query79	1834	595	622	595
query80	1195	436	419	419
query81	538	243	239	239
query82	1184	91	88	88
query83	171	145	140	140
query84	287	80	82	80
query85	1124	303	289	289
query86	405	282	308	282
query87	4392	4252	4262	4252
query88	3919	2376	2459	2376
query89	419	293	288	288
query90	1895	190	190	190
query91	197	148	151	148
query92	61	50	51	50
query93	2481	565	558	558
query94	747	303	302	302
query95	352	270	263	263
query96	645	290	281	281
query97	3265	3179	3115	3115
query98	214	206	195	195
query99	1582	1312	1313	1312
Total cold run time: 313183 ms
Total hot run time: 197077 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.06 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b4fa6bb30c4fc279471f0b588d98ba6c3a845a14, data reload: false

query1	0.04	0.03	0.04
query2	0.06	0.03	0.04
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.53	0.51	0.50
query6	1.14	0.72	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.57	0.49	0.51
query10	0.56	0.56	0.57
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.59	0.60
query14	2.75	2.74	2.77
query15	0.90	0.82	0.83
query16	0.39	0.41	0.38
query17	1.04	0.97	1.06
query18	0.24	0.21	0.20
query19	1.89	1.85	2.00
query20	0.01	0.03	0.02
query21	15.38	0.57	0.60
query22	2.71	2.46	2.29
query23	16.81	0.90	0.83
query24	3.34	0.97	0.38
query25	0.24	0.27	0.07
query26	0.31	0.14	0.14
query27	0.05	0.04	0.04
query28	10.84	0.52	0.50
query29	12.61	3.26	3.25
query30	0.24	0.05	0.06
query31	2.86	0.40	0.39
query32	3.23	0.46	0.45
query33	2.97	2.99	3.01
query34	17.30	4.46	4.46
query35	4.57	4.55	4.55
query36	0.68	0.51	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.03	0.02
query40	0.15	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 107.53 s
Total hot run time: 32.06 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 0577ffd into branch-3.0 Apr 23, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49983-branch-3.0 branch April 23, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants