Skip to content

[fix](variant)fix core in column_object when sort from empty block #50033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025

Conversation

amorynan
Copy link
Contributor

@amorynan amorynan commented Apr 14, 2025

What problem does this PR solve?

backport : #50032
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@amorynan amorynan requested a review from dataroaring as a code owner April 14, 2025 14:59
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40056 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 52e1ce7c8f788b85abccf8a4b5c021665fe109be, data reload: false

------ Round 1 ----------------------------------
q1	17574	6709	6603	6603
q2	2078	179	169	169
q3	10614	1057	1139	1057
q4	10558	765	697	697
q5	7776	2829	2821	2821
q6	223	135	129	129
q7	972	618	611	611
q8	9357	1949	2004	1949
q9	6516	6332	6393	6332
q10	6999	2270	2306	2270
q11	463	275	271	271
q12	391	215	211	211
q13	17790	2976	3008	2976
q14	236	210	214	210
q15	503	459	466	459
q16	675	594	600	594
q17	970	580	548	548
q18	7317	6690	6610	6610
q19	1391	1127	1016	1016
q20	484	211	208	208
q21	4090	3319	3382	3319
q22	1078	996	1015	996
Total cold run time: 108055 ms
Total hot run time: 40056 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6590	6627	6547	6547
q2	330	241	236	236
q3	2912	2747	2930	2747
q4	2001	1789	1788	1788
q5	5735	5837	5742	5742
q6	221	128	132	128
q7	2250	1808	1786	1786
q8	3397	3536	3502	3502
q9	8817	8893	8843	8843
q10	3567	3532	3537	3532
q11	592	508	499	499
q12	824	583	591	583
q13	9508	3202	3188	3188
q14	313	265	281	265
q15	513	474	473	473
q16	692	675	651	651
q17	1843	1620	1597	1597
q18	8337	7690	7538	7538
q19	1649	1489	1559	1489
q20	2102	1905	1860	1860
q21	5545	5397	5493	5397
q22	1133	1019	1001	1001
Total cold run time: 68871 ms
Total hot run time: 59392 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197356 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 52e1ce7c8f788b85abccf8a4b5c021665fe109be, data reload: false

query1	1272	922	949	922
query2	6226	2043	1987	1987
query3	10805	4300	4323	4300
query4	65889	29172	23445	23445
query5	5035	465	484	465
query6	422	189	193	189
query7	5704	325	314	314
query8	319	231	228	228
query9	9522	2611	2603	2603
query10	489	271	265	265
query11	17810	15335	15759	15335
query12	160	104	105	104
query13	1558	461	423	423
query14	10665	6973	7009	6973
query15	215	191	195	191
query16	7614	442	512	442
query17	1052	588	607	588
query18	1828	333	301	301
query19	228	155	172	155
query20	119	110	109	109
query21	206	109	103	103
query22	4745	4527	4387	4387
query23	34112	34568	34410	34410
query24	6297	2884	2965	2884
query25	515	404	412	404
query26	660	168	176	168
query27	1834	365	361	361
query28	4132	2440	2410	2410
query29	683	449	461	449
query30	243	165	164	164
query31	998	836	822	822
query32	73	61	64	61
query33	417	287	296	287
query34	912	505	514	505
query35	849	719	739	719
query36	1093	965	972	965
query37	119	66	65	65
query38	4057	4021	3991	3991
query39	1512	1495	1466	1466
query40	203	105	109	105
query41	53	53	50	50
query42	120	103	103	103
query43	536	483	492	483
query44	1168	833	831	831
query45	186	164	175	164
query46	1159	752	745	745
query47	2077	1923	1947	1923
query48	493	389	395	389
query49	762	412	404	404
query50	847	417	424	417
query51	7305	6960	7136	6960
query52	102	90	88	88
query53	261	184	181	181
query54	584	468	476	468
query55	76	76	77	76
query56	279	260	256	256
query57	1224	1114	1105	1105
query58	228	216	223	216
query59	3181	2916	2889	2889
query60	294	279	278	278
query61	135	150	131	131
query62	774	688	659	659
query63	227	193	204	193
query64	1482	680	652	652
query65	3254	3212	3203	3203
query66	710	303	305	303
query67	15719	15460	15556	15460
query68	3844	602	582	582
query69	441	265	264	264
query70	1174	1131	1087	1087
query71	353	256	250	250
query72	6369	4125	4022	4022
query73	754	356	344	344
query74	10028	9072	9260	9072
query75	3357	2690	2705	2690
query76	1908	1027	1069	1027
query77	486	277	276	276
query78	10646	9556	9651	9556
query79	1166	597	599	597
query80	844	424	431	424
query81	506	246	245	245
query82	1308	90	89	89
query83	246	142	138	138
query84	289	78	80	78
query85	881	359	320	320
query86	338	308	302	302
query87	4440	4259	4310	4259
query88	3588	2427	2403	2403
query89	411	288	292	288
query90	1999	185	187	185
query91	188	154	153	153
query92	63	52	52	52
query93	1319	554	570	554
query94	778	305	252	252
query95	360	268	263	263
query96	612	279	284	279
query97	3333	3173	3140	3140
query98	211	196	194	194
query99	1575	1294	1279	1279
Total cold run time: 317643 ms
Total hot run time: 197356 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.61 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 52e1ce7c8f788b85abccf8a4b5c021665fe109be, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.54	0.53	0.54
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.03	0.03	0.03
query9	0.56	0.52	0.51
query10	0.56	0.56	0.55
query11	0.16	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.59	0.60
query14	2.73	2.85	2.76
query15	0.90	0.84	0.82
query16	0.38	0.40	0.40
query17	1.00	1.02	1.07
query18	0.23	0.23	0.22
query19	1.99	1.82	2.00
query20	0.02	0.01	0.01
query21	15.36	0.61	0.58
query22	2.42	2.77	2.66
query23	17.65	1.05	0.85
query24	3.02	1.51	1.49
query25	0.25	0.36	0.06
query26	0.38	0.14	0.15
query27	0.05	0.05	0.04
query28	9.65	0.51	0.50
query29	12.56	3.28	3.27
query30	0.24	0.06	0.07
query31	2.87	0.39	0.38
query32	3.25	0.46	0.47
query33	2.97	3.01	3.05
query34	16.78	4.42	4.49
query35	4.58	4.46	4.54
query36	0.65	0.52	0.50
query37	0.10	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.14 s
Total hot run time: 33.61 s

@amorynan
Copy link
Contributor Author

run beut

@amorynan
Copy link
Contributor Author

run cloud_p0

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 25.00% (1/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.13% (10514/26198)
Line Coverage 30.75% (88285/287061)
Region Coverage 29.86% (45498/152356)
Branch Coverage 26.22% (23057/87930)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit c767276 into apache:branch-3.0 Apr 18, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants