Skip to content

branch-3.0-pick: [Fix](cloud-mow) Handle tablet delete bitmap calculation task's return value unifiedly in CloudEngineCalcDeleteBitmapTask::execute #50019 #50045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Apr 15, 2025

pick #50019

@bobhan1 bobhan1 requested a review from dataroaring as a code owner April 15, 2025 04:09
@Thearas
Copy link
Contributor

Thearas commented Apr 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 15, 2025

run buildall

@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 15, 2025

run beut

@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 15, 2025

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 40515 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2eee2038678811497a925c5a10735f36e29bdfbf, data reload: false

------ Round 1 ----------------------------------
q1	17565	7072	6643	6643
q2	2188	172	164	164
q3	10760	1076	1162	1076
q4	10539	759	758	758
q5	8157	2833	2799	2799
q6	221	134	130	130
q7	964	612	602	602
q8	9345	1941	2044	1941
q9	6627	6448	6436	6436
q10	7040	2285	2231	2231
q11	464	260	263	260
q12	395	215	207	207
q13	19047	2983	3012	2983
q14	238	207	208	207
q15	507	469	465	465
q16	680	593	589	589
q17	982	559	574	559
q18	7178	6781	6997	6781
q19	1393	1115	1108	1108
q20	481	209	214	209
q21	4150	3328	3432	3328
q22	1186	1065	1039	1039
Total cold run time: 110107 ms
Total hot run time: 40515 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6810	6785	6794	6785
q2	348	249	252	249
q3	3109	3066	2955	2955
q4	2054	1894	1837	1837
q5	5780	5781	5746	5746
q6	203	129	129	129
q7	2232	1767	1765	1765
q8	3375	3540	3522	3522
q9	8676	8823	8973	8823
q10	3592	3555	3568	3555
q11	598	495	498	495
q12	876	592	613	592
q13	13384	3200	3119	3119
q14	295	269	270	269
q15	516	466	479	466
q16	700	657	656	656
q17	1867	1628	1590	1590
q18	8392	7914	7677	7677
q19	1644	1634	1552	1552
q20	2105	1891	1859	1859
q21	5495	5292	5267	5267
q22	1112	1062	1056	1056
Total cold run time: 73163 ms
Total hot run time: 59964 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/14) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.04% (10489/26198)
Line Coverage 30.71% (88151/287059)
Region Coverage 29.81% (45424/152355)
Branch Coverage 26.20% (23032/87924)

@doris-robot
Copy link

TPC-DS: Total hot run time: 196865 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2eee2038678811497a925c5a10735f36e29bdfbf, data reload: false

query1	1265	894	896	894
query2	6225	1992	1986	1986
query3	10902	4515	4349	4349
query4	65456	28616	24048	24048
query5	5031	441	447	441
query6	410	182	185	182
query7	5567	324	310	310
query8	290	211	210	210
query9	8861	2609	2583	2583
query10	456	258	252	252
query11	17545	15139	15685	15139
query12	155	104	104	104
query13	1504	438	465	438
query14	10819	6969	7566	6969
query15	188	172	179	172
query16	7165	503	477	477
query17	1078	584	597	584
query18	1929	328	342	328
query19	226	164	169	164
query20	116	115	112	112
query21	218	103	106	103
query22	4712	4440	4541	4440
query23	35392	33725	33687	33687
query24	6122	2864	2955	2864
query25	537	429	418	418
query26	660	171	170	170
query27	1694	364	371	364
query28	4174	2487	2418	2418
query29	661	438	425	425
query30	253	162	160	160
query31	995	829	814	814
query32	62	59	54	54
query33	393	302	301	301
query34	899	511	515	511
query35	840	762	728	728
query36	1094	965	938	938
query37	115	78	72	72
query38	4017	3958	3987	3958
query39	1495	1462	1486	1462
query40	207	98	99	98
query41	50	48	46	46
query42	122	101	100	100
query43	536	469	474	469
query44	1172	836	815	815
query45	182	163	166	163
query46	1157	721	748	721
query47	2050	1905	1939	1905
query48	482	374	382	374
query49	725	405	393	393
query50	827	419	434	419
query51	7246	6978	7054	6978
query52	102	89	91	89
query53	259	180	176	176
query54	556	449	453	449
query55	74	70	76	70
query56	259	239	247	239
query57	1212	1094	1112	1094
query58	208	197	204	197
query59	2976	2867	2873	2867
query60	265	259	260	259
query61	111	112	127	112
query62	756	672	666	666
query63	213	180	183	180
query64	1353	680	641	641
query65	3290	3252	3245	3245
query66	621	294	308	294
query67	15821	15849	15506	15506
query68	3854	612	596	596
query69	416	265	266	265
query70	1161	1136	1111	1111
query71	319	258	265	258
query72	6159	4036	4041	4036
query73	751	347	348	347
query74	10452	9180	9317	9180
query75	3338	2631	2651	2631
query76	1952	1111	1037	1037
query77	465	277	271	271
query78	10594	9591	9562	9562
query79	1392	586	593	586
query80	857	462	432	432
query81	516	242	237	237
query82	1268	92	91	91
query83	166	142	147	142
query84	283	78	74	74
query85	894	323	291	291
query86	346	278	305	278
query87	4359	4231	4182	4182
query88	3882	2412	2369	2369
query89	404	296	289	289
query90	1861	183	182	182
query91	189	155	150	150
query92	65	47	49	47
query93	1955	565	565	565
query94	725	310	298	298
query95	347	256	260	256
query96	609	285	289	285
query97	3276	3208	3140	3140
query98	211	207	191	191
query99	1584	1292	1308	1292
Total cold run time: 317003 ms
Total hot run time: 196865 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.21 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2eee2038678811497a925c5a10735f36e29bdfbf, data reload: false

query1	0.03	0.03	0.04
query2	0.06	0.03	0.04
query3	0.23	0.06	0.06
query4	1.63	0.11	0.10
query5	0.54	0.51	0.50
query6	1.14	0.72	0.72
query7	0.02	0.02	0.03
query8	0.03	0.03	0.03
query9	0.57	0.52	0.50
query10	0.56	0.55	0.55
query11	0.14	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.59	0.59
query14	2.73	2.73	2.75
query15	0.90	0.83	0.82
query16	0.40	0.38	0.39
query17	1.03	1.05	1.05
query18	0.23	0.22	0.21
query19	1.96	1.84	2.00
query20	0.01	0.01	0.01
query21	15.35	0.60	0.59
query22	2.79	2.79	1.89
query23	17.03	0.94	0.71
query24	3.10	1.17	1.56
query25	0.23	0.22	0.04
query26	0.58	0.14	0.13
query27	0.04	0.05	0.05
query28	9.93	0.48	0.46
query29	12.55	3.27	3.20
query30	0.26	0.05	0.06
query31	2.88	0.39	0.39
query32	3.22	0.46	0.45
query33	2.95	3.03	3.01
query34	17.09	4.53	4.44
query35	4.58	4.52	4.49
query36	0.66	0.49	0.47
query37	0.08	0.06	0.07
query38	0.05	0.03	0.03
query39	0.04	0.03	0.02
query40	0.16	0.11	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 106.7 s
Total hot run time: 32.21 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants