Skip to content

[fix](serde)Fixed the issue that serde may cause be core when reading schema changed text table. (#50105) #50504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

hubgeter
Copy link
Contributor

bp #50105

What problem does this PR solve?

Problem Summary:
When reading a Hive text table that has undergone a schema change,

  1. Hive : add a subcolumn to a struct
    The number of struct subcolumns in the text file may not match the
    number of struct subcolumns in the table. In this case, struct serde may
    cause be core.
  2. Hive :add a column
    The number of file in the text don't match the number of table schema ,
    and set serialization.null.formatescape.delim TBLPROPERTIES,serde
    will modify const static data, cause be core.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

… schema changed text table. (apache#50105)

Problem Summary:
When reading a Hive text table that has undergone a schema change,

1. Hive :   add a subcolumn  to a struct
The number of struct subcolumns in the text file may not match the
number of struct subcolumns in the table. In this case, struct serde may
cause be core.
2. Hive :add a column
The number of file in the text don't match the number of table schema ,
and set `serialization.null.format` , `escape.delim` TBLPROPERTIES,serde
will modify const static data, cause be core.
@hubgeter hubgeter requested a review from yiguolei as a code owner April 28, 2025 08:01
@Thearas
Copy link
Contributor

Thearas commented Apr 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter
Copy link
Contributor Author

run buildall

@hubgeter
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 50.00% (3/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.84% (10270/26439)
Line Coverage 29.91% (85324/285300)
Region Coverage 28.56% (43970/153982)
Branch Coverage 25.29% (22492/88942)

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 29, 2025
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 4e81481 into apache:branch-2.1 Apr 29, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants