Skip to content

Conversation

@catpineapple
Copy link
Contributor

@catpineapple catpineapple commented Apr 29, 2025

What problem does this PR solve?

Add the environment dependency of running CPU profile to the docker base image

Related PR: #40330

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@catpineapple
Copy link
Contributor Author

run buildall

@catpineapple
Copy link
Contributor Author

run buildall

intelligentfu8
intelligentfu8 previously approved these changes Apr 29, 2025
Copy link

@intelligentfu8 intelligentfu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 29, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

zy-kkk
zy-kkk previously approved these changes Apr 29, 2025
@catpineapple catpineapple dismissed stale reviews from zy-kkk and intelligentfu8 via 587f82b April 29, 2025 07:31
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 29, 2025
@zy-kkk zy-kkk self-requested a review April 29, 2025 07:34
Copy link

@intelligentfu8 intelligentfu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 29, 2025
@catpineapple
Copy link
Contributor Author

run buildall

@shuke987
Copy link
Collaborator

skip buildall

@catpineapple catpineapple merged commit b5bb57a into apache:master Apr 29, 2025
30 checks passed
@catpineapple catpineapple deleted the perf-base-image branch April 30, 2025 02:21
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
apache#50536)

### What problem does this PR solve?

Add the environment dependency of running CPU profile to the docker base
image

Related PR: apache#40330 

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [x] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [x] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants