Skip to content

branch-3.0: [Bug](agg-state) fix agg state inner type not conversioned #50418 #50575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
May 7, 2025
Merged

branch-3.0: [Bug](agg-state) fix agg state inner type not conversioned #50418 #50575

dataroaring merged 1 commit into from
May 7, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 30, 2025

Cherry-picked from #50418

@BiteTheDDDDt
[Bug](agg-state) fix agg state inner type not conversioned (#50418)
76d084c 
### What problem does this PR solve?


drop table if exists t01;
create table t01(id int, decimal_col agg_state<sum(decimal(20,6))>
generic) properties ("replication_num" = "1");
insert into t01 values (1, sum_state(10.1)), (1, sum_state(20.1)), (2,
sum_state(10.2)), (2, sum_state(11.0));
select sum_merge(decimal_col) from t01 group by id;
 

[18:36]MySQL [email protected]:test_agg_state> select
sum_merge(decimal_col) from t01 group by id; (1105, "errCode = 2,
detailMessage =
(172.20.48.119)[INTERNAL_ERROR]AggState(function_name=sum,result_is_nullable=true,arguments=[Nullable(Decimal(27,
9))],be_exec_version=8)'s expect return type is Nullable(Decimal(27,
9)), but input Nullable(Decimal(76, 6))") [18:36]MySQL
[email protected]:test_agg_state>


### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from dataroaring as a code owner April 30, 2025 10:21
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 30, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 30, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 30, 2025

TPC-H: Total hot run time: 40013 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 76d084c1584d05213a68d284bc9c8764f470fca4, data reload: false

------ Round 1 ----------------------------------
q1	17612	6736	6680	6680
q2	2070	169	159	159
q3	10609	1089	1177	1089
q4	10531	735	723	723
q5	7740	2889	2804	2804
q6	223	137	135	135
q7	960	633	602	602
q8	9354	1920	2015	1920
q9	6658	6383	6404	6383
q10	7003	2295	2301	2295
q11	481	270	260	260
q12	401	218	209	209
q13	17780	3007	2946	2946
q14	229	214	205	205
q15	504	474	457	457
q16	675	580	579	579
q17	978	556	530	530
q18	7366	6616	6683	6616
q19	1412	1110	1052	1052
q20	476	207	211	207
q21	4093	3186	3267	3186
q22	1070	976	996	976
Total cold run time: 108225 ms
Total hot run time: 40013 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6651	6608	6572	6572
q2	334	240	223	223
q3	2883	2747	2958	2747
q4	2037	1794	1813	1794
q5	5805	5734	5724	5724
q6	209	126	131	126
q7	2249	1855	1812	1812
q8	3380	3583	3514	3514
q9	8940	8851	8930	8851
q10	3572	3544	3516	3516
q11	602	497	510	497
q12	835	656	602	602
q13	7029	3171	3187	3171
q14	308	273	277	273
q15	510	465	464	464
q16	683	649	656	649
q17	1859	1618	1616	1616
q18	8148	7807	7659	7659
q19	1711	1648	1547	1547
q20	2035	1823	1833	1823
q21	5578	5339	5430	5339
q22	1117	1048	995	995
Total cold run time: 66475 ms
Total hot run time: 59514 ms

@doris-robot
Copy link

doris-robot commented Apr 30, 2025

TPC-DS: Total hot run time: 197401 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 76d084c1584d05213a68d284bc9c8764f470fca4, data reload: false

query1	1285	899	897	897
query2	6301	2058	2047	2047
query3	10810	4355	4172	4172
query4	62217	35127	23691	23691
query5	5195	448	437	437
query6	314	172	171	171
query7	4902	325	329	325
query8	290	238	238	238
query9	6270	2677	2642	2642
query10	431	276	259	259
query11	15760	15187	15708	15187
query12	164	104	103	103
query13	1055	457	441	441
query14	10409	6777	7168	6777
query15	202	183	177	177
query16	7173	489	485	485
query17	1270	597	575	575
query18	1928	346	327	327
query19	223	172	169	169
query20	125	114	111	111
query21	209	103	105	103
query22	4809	4678	4621	4621
query23	34504	33831	34438	33831
query24	6369	2966	2965	2965
query25	532	435	437	435
query26	657	174	172	172
query27	1915	380	385	380
query28	4438	2527	2461	2461
query29	754	450	433	433
query30	243	158	160	158
query31	992	776	803	776
query32	67	54	56	54
query33	399	299	311	299
query34	944	526	518	518
query35	862	728	727	727
query36	1086	980	997	980
query37	118	66	72	66
query38	4068	3920	3963	3920
query39	1531	1477	1483	1477
query40	211	94	106	94
query41	51	51	48	48
query42	112	105	103	103
query43	552	495	496	495
query44	1195	838	817	817
query45	187	164	167	164
query46	1185	761	734	734
query47	2027	1898	1916	1898
query48	491	401	399	399
query49	716	394	403	394
query50	861	421	421	421
query51	7449	7243	7516	7243
query52	103	96	91	91
query53	268	202	192	192
query54	608	480	488	480
query55	80	81	81	81
query56	263	255	244	244
query57	1254	1197	1127	1127
query58	220	210	227	210
query59	3427	3224	3058	3058
query60	280	253	253	253
query61	113	110	107	107
query62	766	697	656	656
query63	220	188	187	187
query64	1411	672	707	672
query65	3264	3248	3201	3201
query66	738	299	297	297
query67	16009	15488	15726	15488
query68	3598	601	593	593
query69	425	266	261	261
query70	1164	1134	1106	1106
query71	366	256	252	252
query72	6361	4109	3992	3992
query73	770	356	361	356
query74	10257	9073	9028	9028
query75	3387	2668	2646	2646
query76	1989	1037	1030	1030
query77	506	276	286	276
query78	10806	9647	9607	9607
query79	1750	600	617	600
query80	876	447	422	422
query81	517	239	238	238
query82	1273	91	86	86
query83	243	147	147	147
query84	280	77	78	77
query85	1025	304	297	297
query86	334	297	302	297
query87	4435	4213	4267	4213
query88	4123	2454	2399	2399
query89	424	296	297	296
query90	2047	185	188	185
query91	180	148	149	148
query92	64	51	54	51
query93	2190	575	576	575
query94	758	312	311	311
query95	363	263	261	261
query96	631	284	288	284
query97	3341	3137	3113	3113
query98	218	201	199	199
query99	1566	1309	1294	1294
Total cold run time: 311149 ms
Total hot run time: 197401 ms

@doris-robot
Copy link

doris-robot commented Apr 30, 2025

ClickBench: Total hot run time: 31.74 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 76d084c1584d05213a68d284bc9c8764f470fca4, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.51	0.53	0.54
query6	1.14	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.55	0.50	0.50
query10	0.56	0.55	0.55
query11	0.15	0.11	0.13
query12	0.14	0.12	0.11
query13	0.61	0.60	0.59
query14	2.71	2.81	2.76
query15	0.89	0.82	0.83
query16	0.38	0.40	0.39
query17	1.08	1.08	1.05
query18	0.25	0.23	0.22
query19	1.87	1.82	1.97
query20	0.01	0.01	0.02
query21	15.36	0.61	0.57
query22	2.88	2.80	1.78
query23	17.05	0.93	0.75
query24	3.39	0.62	1.20
query25	0.27	0.04	0.06
query26	0.44	0.14	0.14
query27	0.05	0.04	0.04
query28	10.37	0.53	0.46
query29	12.56	3.25	3.29
query30	0.25	0.06	0.06
query31	2.86	0.38	0.39
query32	3.26	0.48	0.45
query33	2.97	3.03	3.05
query34	17.14	4.47	4.49
query35	4.48	4.46	4.53
query36	0.66	0.49	0.49
query37	0.10	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 107.36 s
Total hot run time: 31.74 s

dataroaring
dataroaring approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 6, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented May 6, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented May 6, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 6bc495f into branch-3.0 May 7, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-50418-branch-3.0 branch May 7, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @doris-robot @dataroaring @BiteTheDDDDt