-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[refine](condition) Change conditional functions to native expr #58125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 35324 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34113 ms |
TPC-DS: Total hot run time: 188387 ms |
ClickBench: Total hot run time: 27.74 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 35178 ms |
TPC-DS: Total hot run time: 188826 ms |
ClickBench: Total hot run time: 27.5 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
6ee0783 to
fe4dfb6
Compare
|
run buildall |
TPC-H: Total hot run time: 34326 ms |
TPC-DS: Total hot run time: 187151 ms |
ClickBench: Total hot run time: 27.17 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 35606 ms |
TPC-DS: Total hot run time: 187265 ms |
ClickBench: Total hot run time: 27.61 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 35661 ms |
TPC-DS: Total hot run time: 187628 ms |
ClickBench: Total hot run time: 27.62 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34250 ms |
TPC-DS: Total hot run time: 184655 ms |
ClickBench: Total hot run time: 27.76 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run nonConcurrent |
What problem does this PR solve?
Previously our conditional functions used the function framework.
For example: if(cond, exprA, exprB). Before executing if, cond, exprA, and exprB were already evaluated.
By switching to expr, we can choose to evaluate either exprA or exprB based on the actual value of cond.
Switching to expr also paves the way to support short-circuit evaluation in the future.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)