Skip to content

[Fix](package)Revert be-extension package management changes due to class loading issues #58255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix](package)Revert be-extension package management changes due to class loading issues #58255

wants to merge 1 commit into from

Conversation

@CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Nov 22, 2025 •
edited
Loading

#57979

This PR reverts recent modifications to the be-extension package management. The changes introduced class loading problems that caused the hadoop-jin catalog system tables to become unusable.

@CalvinKirs
[Fix](Revert)Revert be-extension package management changes due to cl…
b598ae1 
…ass loading issues

This PR reverts recent modifications to the be-extension package management. The changes introduced class loading problems that caused the hadoop-jin catalog system tables to become unusable.
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs CalvinKirs changed the title [Fix](Revert)Revert be-extension package management changes due to class loading issues [Fix](package)Revert be-extension package management changes due to class loading issues Nov 22, 2025
@CalvinKirs
Copy link
Member Author

CalvinKirs commented Nov 22, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Nov 22, 2025

TPC-H: Total hot run time: 35892 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b598ae1568c2a78c97cce3685175af54a2deef5e, data reload: false

------ Round 1 ----------------------------------
q1	17610	5061	4982	4982
q2	1994	299	217	217
q3	10257	1282	753	753
q4	10239	977	392	392
q5	7591	2425	2323	2323
q6	190	172	140	140
q7	945	790	650	650
q8	9379	1335	1058	1058
q9	7094	5365	5450	5365
q10	6876	2211	1831	1831
q11	510	308	297	297
q12	360	371	232	232
q13	18274	3798	3190	3190
q14	234	239	223	223
q15	586	508	513	508
q16	1073	1030	968	968
q17	608	888	383	383
q18	8020	7838	8051	7838
q19	1640	1011	602	602
q20	407	355	244	244
q21	4450	3765	2576	2576
q22	1178	1180	1120	1120
Total cold run time: 109515 ms
Total hot run time: 35892 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5256	5161	5282	5161
q2	353	383	318	318
q3	2387	2874	2465	2465
q4	1450	1808	1449	1449
q5	4655	4514	4452	4452
q6	291	215	150	150
q7	1928	1882	1801	1801
q8	2532	2591	2590	2590
q9	7707	7632	7635	7632
q10	3088	3091	2653	2653
q11	556	502	488	488
q12	624	709	581	581
q13	3321	3637	3116	3116
q14	275	279	260	260
q15	529	509	487	487
q16	1017	1050	1005	1005
q17	1108	1394	1323	1323
q18	7267	7188	7161	7161
q19	793	758	838	758
q20	1895	2001	1808	1808
q21	4756	4370	4279	4279
q22	1083	1033	1030	1030
Total cold run time: 52871 ms
Total hot run time: 50967 ms

@doris-robot
Copy link

doris-robot commented Nov 22, 2025

TPC-DS: Total hot run time: 185574 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b598ae1568c2a78c97cce3685175af54a2deef5e, data reload: false

query1	1044	413	388	388
query2	6561	1642	1721	1642
query3	6756	239	226	226
query4	26379	22978	23116	22978
query5	4451	668	485	485
query6	347	252	235	235
query7	4642	495	300	300
query8	304	266	253	253
query9	8739	2593	2574	2574
query10	505	352	316	316
query11	15750	15097	14858	14858
query12	194	121	115	115
query13	1715	593	456	456
query14	11330	9201	9184	9184
query15	206	184	175	175
query16	7695	713	540	540
query17	1292	753	602	602
query18	2022	407	318	318
query19	215	200	173	173
query20	131	133	124	124
query21	215	135	114	114
query22	4017	4012	4022	4012
query23	34014	32968	33024	32968
query24	8429	2384	2400	2384
query25	580	532	441	441
query26	1238	272	166	166
query27	2745	489	352	352
query28	4385	2161	2139	2139
query29	800	615	489	489
query30	296	225	199	199
query31	926	785	712	712
query32	89	73	73	73
query33	614	396	320	320
query34	793	903	539	539
query35	822	821	769	769
query36	944	985	922	922
query37	122	120	91	91
query38	3491	3544	3508	3508
query39	1507	1413	1589	1413
query40	220	125	119	119
query41	67	60	62	60
query42	125	112	111	111
query43	489	480	452	452
query44	1229	775	766	766
query45	189	178	170	170
query46	888	1010	637	637
query47	1747	1790	1727	1727
query48	386	423	312	312
query49	784	500	429	429
query50	655	680	410	410
query51	3891	3996	3925	3925
query52	109	114	101	101
query53	245	261	197	197
query54	310	292	282	282
query55	87	84	86	84
query56	341	311	342	311
query57	1163	1186	1115	1115
query58	285	274	276	274
query59	2582	2689	2512	2512
query60	350	350	318	318
query61	165	183	159	159
query62	791	712	664	664
query63	237	192	194	192
query64	4457	1176	859	859
query65	4033	3938	3951	3938
query66	1102	436	333	333
query67	15200	15007	15106	15007
query68	8284	898	646	646
query69	495	330	289	289
query70	1358	1249	1298	1249
query71	471	342	330	330
query72	5396	4822	2828	2828
query73	648	609	372	372
query74	8995	9188	8847	8847
query75	3604	3303	2797	2797
query76	3378	1125	728	728
query77	575	397	343	343
query78	9676	9794	8979	8979
query79	1714	835	604	604
query80	786	609	609	609
query81	489	257	218	218
query82	425	161	127	127
query83	275	265	250	250
query84	254	123	106	106
query85	895	491	445	445
query86	342	311	302	302
query87	3714	3764	3571	3571
query88	2831	2228	2281	2228
query89	387	330	290	290
query90	1779	231	222	222
query91	168	162	136	136
query92	69	70	67	67
query93	1154	987	681	681
query94	634	451	340	340
query95	400	323	315	315
query96	487	579	280	280
query97	2884	3004	2864	2864
query98	246	209	225	209
query99	1319	1375	1285	1285
Total cold run time: 272564 ms
Total hot run time: 185574 ms

@doris-robot
Copy link

doris-robot commented Nov 22, 2025

ClickBench: Total hot run time: 27.43 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b598ae1568c2a78c97cce3685175af54a2deef5e, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.09
query4	1.60	0.12	0.11
query5	0.28	0.25	0.27
query6	1.17	0.66	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.58	0.52	0.51
query10	0.56	0.57	0.58
query11	0.16	0.12	0.12
query12	0.16	0.12	0.13
query13	0.63	0.61	0.61
query14	1.01	0.99	0.99
query15	0.85	0.83	0.83
query16	0.39	0.40	0.39
query17	1.04	1.05	0.99
query18	0.21	0.19	0.20
query19	1.93	1.79	1.82
query20	0.04	0.01	0.01
query21	15.43	0.19	0.13
query22	5.02	0.06	0.04
query23	15.66	0.26	0.11
query24	2.36	0.97	0.30
query25	0.07	0.06	0.06
query26	0.16	0.13	0.12
query27	0.06	0.06	0.06
query28	3.74	1.14	0.93
query29	12.60	3.86	3.24
query30	0.29	0.14	0.11
query31	2.82	0.58	0.39
query32	3.23	0.56	0.47
query33	2.97	3.07	3.20
query34	15.91	5.24	4.63
query35	4.49	4.63	4.56
query36	0.68	0.51	0.48
query37	0.10	0.07	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.12 s
Total hot run time: 27.43 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 22, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/4.0.x reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CalvinKirs @hello-stephen @doris-robot @morningman