Skip to content

branch-4.0: [bugfix](memory) should count memory when cancel query is called #58252 #58256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: branch-4.0
Choose a base branch
from
Open

branch-4.0: [bugfix](memory) should count memory when cancel query is called #58252 #58256

wants to merge 1 commit into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 22, 2025

Cherry-picked from #58252

@yiguolei
[bugfix](memory) should count memory when cancel query is called (#58252
018a689 
)

*** Current BE git commitID: 4945aa0 ***
*** SIGABRT unknown detail explain (@0x3c54) received by PID 15444 (TID
16396 OR 0x7b2e9f39b700) from PID 15444; stack trace: ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int,
siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420
 1# 0x00007F3421D1D420 in /lib/x86_64-linux-gnu/libpthread.so.0
 2# raise at ../sysdeps/unix/sysv/linux/raise.c:51
 3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81
4# 0x000055A425A57985 in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
5# 0x000055A425A4923A in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
6# google::LogMessage::SendToLog() in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
7# google::LogMessage::Flush() in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
8# google::LogMessageFatal::~LogMessageFatal() in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
9# doris::Status doris::Status::FatalError<true,
std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> >&>(std::basic_string_view<char,
std::char_traits<char> >, std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> >&) at
/root/doris/be/src/common/status.h:467
10# doris::io::LocalFileReader::read_at_impl(unsigned long,
doris::Slice, unsigned long*, doris::io::IOContext const*) at
/root/doris/be/src/io/fs/local_file_reader.cpp:151
11# doris::io::FileReader::read_at(unsigned long, doris::Slice, unsigned
long*, doris::io::IOContext const*) at
/root/doris/be/src/io/fs/file_reader.cpp:34
12# doris::io::S3FileSystem::upload_impl(std::filesystem::__cxx11::path
const&, std::filesystem::__cxx11::path const&) at
/root/doris/be/src/io/fs/s3_file_system.cpp:339
13# doris::io::RemoteFileSystem::upload(std::filesystem::__cxx11::path
const&, std::filesystem::__cxx11::path const&) at
/root/doris/be/src/io/fs/remote_file_system.cpp:34
14# doris::RuntimeState::get_error_log_file_path[abi:cxx11]() at
/root/doris/be/src/runtime/runtime_state.cpp:418
15#
doris::pipeline::PipelineFragmentContext::get_load_error_url[abi:cxx11]()
at /root/doris/be/src/pipeline/pipeline_fragment_context.cpp:1806
16# doris::pipeline::PipelineFragmentContext::cancel(doris::Status) at
/root/doris/be/src/pipeline/pipeline_fragment_context.cpp:202
17# doris::QueryContext::cancel_all_pipeline_context(doris::Status
const&, int) in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
18# doris::QueryContext::cancel(doris::Status, int) in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
19# doris::FragmentMgr::cancel_query(doris::TUniqueId, doris::Status) at
/root/doris/be/src/runtime/fragment_mgr.cpp:915
20# std::_Function_handler<void (),
doris::PInternalService::cancel_plan_fragment(google::protobuf::RpcController*,
doris::PCancelPlanFragmentRequest const*,
doris::PCancelPlanFragmentResult*,
google::protobuf::Closure*)::$_0>::_M_invoke(std::_Any_data const&) at
/usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:292
21# doris::WorkThreadPool<false>::work_thread(int) in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
22# execute_native_thread_routine in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
23# asan_thread_start(void*) in
/home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from yiguolei as a code owner November 22, 2025 12:51
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 22, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 22, 2025

BE UT Coverage Report

Increment line coverage 92.86% (13/14) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.79% (18153/34384)
Line Coverage 38.13% (165291/433455)
Region Coverage 33.16% (128432/387323)
Branch Coverage 33.94% (55347/163078)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen @doris-robot @yiguolei