[fix](insert-overwrite) skip deleted partitions before replace to avoid DdlException#60914
Merged
morrySnow merged 1 commit intoapache:masterfrom Mar 2, 2026
Merged
[fix](insert-overwrite) skip deleted partitions before replace to avoid DdlException#60914morrySnow merged 1 commit intoapache:masterfrom
morrySnow merged 1 commit intoapache:masterfrom
Conversation
…id DdlException When performing insert overwrite on a whole table, partition names are snapshotted at planning time without holding the table lock. A concurrent DROP PARTITION between the snapshot and the replace step causes Env.replaceTempPartition() to throw DdlException because the original partition no longer exists. Fix: after acquiring the table write lock in InsertOverwriteUtil.replacePartition(), filter out any original partitions that have been deleted before constructing ReplacePartitionOp. The temp partition list is kept intact so all written data remains visible.
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
TPC-H: Total hot run time: 28900 ms |
TPC-DS: Total hot run time: 184762 ms |
starocean999
approved these changes
Mar 2, 2026
seawinde
approved these changes
Mar 2, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Mar 2, 2026
…place to avoid DdlException apache#60914 picked from apache#60914
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Mar 2, 2026
…place to avoid DdlException apache#60914 picked from apache#60914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When performing insert overwrite on a whole table, partition names are snapshotted at planning time without holding the table lock. A concurrent DROP PARTITION between the snapshot and the replace step causes Env.replaceTempPartition() to throw DdlException because the original partition no longer exists.
Fix: after acquiring the table write lock in InsertOverwriteUtil.replacePartition(), filter out any original partitions that have been deleted before constructing ReplacePartitionOp. The temp partition list is kept intact so all written data remains visible.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)