-
Notifications
You must be signed in to change notification settings - Fork 26.5k
[3.3] Optimize TriRpcStatus by adding http status code to its description #15708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15708 +/- ##
============================================
- Coverage 61.05% 61.02% -0.03%
+ Complexity 11704 11696 -8
============================================
Files 1923 1923
Lines 87081 87081
Branches 13115 13115
============================================
- Hits 53165 53141 -24
- Misses 28479 28486 +7
- Partials 5437 5454 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...riple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/AbstractTripleClientStream.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change?
When the provider which try to enable servlet for triple at springboot3 but it doesn't import
dubbo-spring-boot-3-autoconfigure
into its pom.xml, the consumer will encounter RpcException like this,however,
UNIMPLEMENTED : invalid content-type: application/json
is inaccurate, it might be better to sayUNIMPLEMENTED : HTTP status 404, content-type: application/json
.Checklist