-
Notifications
You must be signed in to change notification settings - Fork 19.8k
feat(custom): support compoundPath in custom series renderItem #20402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the This PR depends on ZRender changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time). |
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20402@9fb4073 |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
} | ||
const Clz = graphicUtil.getShapeClass(path.type); | ||
if (!Clz) { | ||
if (typeof path.buildPath === 'function') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think probably we should not public that buildPath
.
- That function is not officially public in any other place, including not public in custom series path.
- If publish
buildPath
function, the signature must not be changed or need backward compat when changing. And the parameter ofbuildPath
includesctx
, which isPathProxy
orCanvasContext
. Although they are always accessible never be officially public and promised in API stability.
Is it needed in some scenarios? @Ovilia
Brief Information
This pull request is in the type of:
What does this PR do?
This PR supports compoundPath in custom series renderItem. It can be used as:
Fixed issues
Details
Before: What was the problem?
compondPath
is not supported so that we cannot make complex objects that looks like the union of shapes. If such shapes have opacity and intersection, it's hard to implement without a compoundPath.After: How does it behave after the fixing?
compondPath
is supported.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information