Skip to content

feat(chord): new chord series #20522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Apr 7, 2025
Merged

feat(chord): new chord series #20522

merged 32 commits into from
Apr 7, 2025

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Nov 18, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Details

The following are some highlights of the Chord implemented by this Pull Request.

Edges With Gradient

image

Other values include 'target' (using target color as edge color) and 'source' (using source color as edge color).

focus.emphasis Behaves Similar To Sankey

image

This is effect of focus: 'adjacency', which I use as the default value since it looks well and the interaction is more intuitive. Other values include 'none'and'self'`.

minAngle and padAngle

image

The current implementation of minAngle and padAngle have bugs with Pie Series (#20603) and Sunburst (#20602), so I re-implemented the logic in Chord Series. The bugs can be fixed with Pie and Sunburst in the future with the similar implementation of Chord.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@Ovilia Ovilia added this to the 6.0.0 milestone Nov 18, 2024
Copy link

echarts-bot bot commented Nov 18, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20522@87599b5

@Ovilia Ovilia marked this pull request as ready for review February 18, 2025 09:48
Copy link

echarts-bot bot commented Feb 18, 2025

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added the PR: awaiting doc Document changes is required for this PR. label Feb 18, 2025
@pissang
Copy link
Contributor

pissang commented Mar 18, 2025

It looks beautiful.

Curious about the decision that padAngle will be set to 0 when padAngle * nodeCount >= PI * 2 instead of decreasing the padAngle until it fits.

@Ovilia
Copy link
Contributor Author

Ovilia commented Mar 24, 2025

@pissang Thanks for the review!

Curious about the decision that padAngle will be set to 0 when padAngle * nodeCount >= PI * 2 instead of decreasing the padAngle until it fits.

How do you define until it fits? For example, if padAngle is 60 degrees and nodeCount is 10, do you mean padAngle should be 360 / 10 = 36 degree? If so, then all space is used for padAngle and shows no sector at all, which I don't think should be intuitive.

@pissang
Copy link
Contributor

pissang commented Mar 24, 2025

I'm thinking of constraints similar to the rules in flexbox, but I'm not sure yet what exactly those rules would be.

The main issue is that the overflow transition should be smooth, not just snap back to zero. That way, users won’t feel that jarring jump when crossing the threshold. As for what you mentioned about showing no sector at all — I assume that currently, at the exact threshold point(padAngle * nodeCount == PI * 2), it is also fully hidden?

@Ovilia
Copy link
Contributor Author

Ovilia commented Mar 25, 2025

@pissang I agree about using transition should be great if appliable.

Currently, at the exact threshold point(padAngle * nodeCount == PI * 2), padAngle would be 0 and sectors will have angles linear mapping to their values.

@Ovilia Ovilia merged commit 3ff94c5 into v6 Apr 7, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in ECharts 6.0 Apr 7, 2025
Copy link

echarts-bot bot commented Apr 7, 2025

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the feat-chord branch April 7, 2025 06:49
@kingyue737 kingyue737 mentioned this pull request Apr 21, 2025
9 tasks
@Ovilia Ovilia changed the title feat: Chord charts feat(chord): new chord series Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/XXL
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants