Skip to content

fix(series): mismatched dimension index when canOmitUnusedDimensions is true #20682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

Justin-ZS
Copy link
Contributor

@Justin-ZS Justin-ZS commented Jan 13, 2025

Close #20672

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix(series): mismatched dimension index when canOmitUnusedDimensions is true.
See more details in #20672

Fixed issues

#20672

Details

Before: What was the problem?

#20672

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jan 13, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@Justin-ZS
Copy link
Contributor Author

@Ovilia Could you help to review the PR? Thanks!

@Justin-ZS
Copy link
Contributor Author

Justin-ZS commented Feb 21, 2025

@100pah @plainheart
Could you help to review this PR? Thanks!

@Justin-ZS
Copy link
Contributor Author

@pissang Could you help to review this PR? Thanks!

@100pah 100pah merged commit f738e27 into apache:master Mar 6, 2025
Copy link

echarts-bot bot commented Mar 6, 2025

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 6.0.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] canOmitUnusedDimensions will mess up the dimension indexes
3 participants