Skip to content

fix(pie): fix labelLine may be not removed and cause error when single label position is not in outside #20906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

fix(pie): fix labelLine may be not removed and cause error when single label position is not in outside #20906

merged 1 commit into from
Apr 9, 2025
+52 −3

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This fixes an error introduced in #14017, which gets label position from series model rather than data item model.

Fixed issues

Comparison

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the 9th test case in test/pie-label.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@plainheart
fix(pie): fix labelLine may be not removed and cause error when singl…
b9e5bb0 
…e label position is not in outside.

- This fixes an error introduced in #14017, which gets label position from series model rather than data item model.
- Resolves #20904
- Resolves #20905
@plainheart plainheart added this to the 6.0.0 milestone Apr 9, 2025
@plainheart plainheart requested review from pissang and susiwen8 April 9, 2025 02:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20906@b9e5bb0

susiwen8
susiwen8 approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@susiwen8 susiwen8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Thanks!

@plainheart plainheart merged commit b407027 into master Apr 9, 2025
2 checks passed
@echarts-bot ECharts Bot
Copy link

echarts-bot bot commented Apr 9, 2025

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/pie/labelLine-remove-error branch April 9, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susiwen8 susiwen8 susiwen8 approved these changes

@pissang pissang Awaiting requested review from pissang

Assignees
No one assigned
Labels
PR: author is committer PR: doc unchanged size/XS
Projects
None yet
Milestone
6.0.0
2 participants
@plainheart @susiwen8