Skip to content

Conversation

@RocMarshal
Copy link
Contributor

@RocMarshal RocMarshal commented Dec 17, 2025

  • [FLINK-38801][benchmark] Adjust code lines format and corresponding namings to follow Google AOSP style.
  • [FLINK-38801][benchmark] Add Spotless and checkstyle plugins with Google AOSP style for flink benchmark repository
    • The two files about spotless and checkstyle are copied from flink repo

@RocMarshal
Copy link
Contributor Author

Hi, @Zakelly Could you help take a look if you had the free time ?
Thank you~

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement.

@RocMarshal
Copy link
Contributor Author

Thanks @Zakelly a lot for the review.
Merging...

@RocMarshal RocMarshal merged commit 9ac3569 into apache:master Jan 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants