-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BP-1.20][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities #25830
Conversation
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
################################################################################ | ||
if ! npm list -g @wbmnky/license-report-generator > /dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest a comment detailing what the shell script does, why is would be useful and when to run it.
@@ -108,6 +108,13 @@ re-compilation: | |||
$ npm run lint | |||
``` | |||
|
|||
### How to update the NOTICE | |||
> Tip: If you've made a modification to any of the dependencies, make sure you've run `dev/generate_notice` before committing to update the `NOTICE` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should say npm dependancies I think.
@flinkbot run azure |
7ca8dbb
to
ddc989b
Compare
@flinkbot run azure |
waiting for a clean CI then will approve |
@davidradl are you OK with merging? |
…ulnerabilities (apache#25718) Follow up of https://issues.apache.org/jira/browse/FLINK-36739 Contribute-to: https://issues.apache.org/jira/browse/FLINK-36740
ddc989b
to
d19d251
Compare
@mehdid93 I already rebased your branch, CI is green. |
Ah, OK, thanks for the clarification. Does that mean we are deviating from the original commit from master? If so, please add a note in the PR description what exactly got changed. |
@afedulov No, we're not deviating from the original commit, it's the same thing, but since package and package-lock were affected in both PRs, the conflicts were resolved by taking package-lock and package from the original commit (this PR), since they're the most recent state. |
What is the purpose of the change
This PR backport the changes done of the PR made by me in (#25718) in master for version 1.20.X to be used in dependencies upgrade and vulnerabilities fixes.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation