Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.20][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities #25830

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mehdid93
Copy link
Contributor

What is the purpose of the change

This PR backport the changes done of the PR made by me in (#25718) in master for version 1.20.X to be used in dependencies upgrade and vulnerabilities fixes.

Brief change log

  • Update of the dependencies

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 20, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

# See the License for the specific language governing permissions and
# limitations under the License.
################################################################################
if ! npm list -g @wbmnky/license-report-generator > /dev/null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a comment detailing what the shell script does, why is would be useful and when to run it.

@@ -108,6 +108,13 @@ re-compilation:
$ npm run lint
```

### How to update the NOTICE
> Tip: If you've made a modification to any of the dependencies, make sure you've run `dev/generate_notice` before committing to update the `NOTICE` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should say npm dependancies I think.

@afedulov
Copy link
Contributor

afedulov commented Jan 4, 2025

@flinkbot run azure

@afedulov
Copy link
Contributor

afedulov commented Jan 7, 2025

@flinkbot run azure

@davidradl
Copy link
Contributor

waiting for a clean CI then will approve

@afedulov
Copy link
Contributor

afedulov commented Jan 8, 2025

@davidradl are you OK with merging?

@afedulov
Copy link
Contributor

afedulov commented Jan 9, 2025

@mehdid93 I already rebased your branch, CI is green.

@mehdid93
Copy link
Contributor Author

mehdid93 commented Jan 9, 2025

@afedulov Thanks a lot for rebasing and merging the PRs. I've rebased because when I've opened this PR there was some conflicts shown in github with package.json and package-lock.json after the merge of the previous PR (#25829) and this one have conflicts in package-lock.json and package.json

@afedulov
Copy link
Contributor

afedulov commented Jan 9, 2025

Ah, OK, thanks for the clarification. Does that mean we are deviating from the original commit from master? If so, please add a note in the PR description what exactly got changed.

@mehdid93
Copy link
Contributor Author

mehdid93 commented Jan 9, 2025

@afedulov No, we're not deviating from the original commit, it's the same thing, but since package and package-lock were affected in both PRs, the conflicts were resolved by taking package-lock and package from the original commit (this PR), since they're the most recent state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants