[FLINK-37408] Update all docker-compose references to docker compose #26239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmadhab
changed the title
davidradl
reviewed
Mar 5, 2025
| @@ -83,7 +83,7 @@ Job 监控以及资源管理。Flink TaskManager 运行 worker 进程， | |||
| 环境搭建只需要几步就可以完成，我们将会带你过一遍必要的操作命令， | |||
| 并说明如何验证我们正在操作的一切都是运行正常的。 | |||
|
|
|||
| 你需要在自己的主机上提前安装好 [docker](https://docs.docker.com/) (1.12+) 和 | |||
| 你需要在自己的主机上提前安装好 [docker](https://docs.docker.com/) (20.10+) 和 | |||
| [docker-compose](https://docs.docker.com/compose/) (2.1+)。 | |||
There was a problem hiding this comment.
nit: docker-compose -> docker compose
davidradl
reviewed
Mar 5, 2025
| @@ -89,7 +89,7 @@ output of the Flink job should show 1000 views per page and window. | |||
| The playground environment is set up in just a few steps. We will walk you through the necessary | |||
| commands and show how to validate that everything is running correctly. | |||
|
|
|||
| We assume that you have [Docker](https://docs.docker.com/) (1.12+) and | |||
| We assume that you have [Docker](https://docs.docker.com/) (20.10+) and | |||
| [docker-compose](https://docs.docker.com/compose/) (2.1+) installed on your machine. | |||
There was a problem hiding this comment.
nit: docker-compose -> docker compose
davidradl
reviewed
Mar 5, 2025
| @@ -316,7 +316,7 @@ jobs: | |||
| maven_repo_folder: ${{ env.MAVEN_REPO_FOLDER }} | |||
|
|
|||
| - name: "Install missing packages" | |||
| run: sudo apt-get install -y net-tools docker-compose zip | |||
| run: sudo apt-get install -y net-tools docker compose zip | |||
There was a problem hiding this comment.
is this right. We are installing docker-compose not using the command line docker-compose. l suspect that we want to remove the word compose; as we are not installing something called compose. I suggest
run: sudo apt-get install -y net-tools docker zip
|
@flinkbot run azure |
|
@davidradl any update here ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Replace all instances of "docker-compose" with "docker compose" throughout the Flink documentation to align with Docker's current CLI naming convention.
https://issues.apache.org/jira/browse/FLINK-37408
Brief change log
Replace all instances of "docker-compose" with "docker compose" throughout the Flink documentation
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation