Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37422][docs] Fix typo in streaming analytics zh document #26249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ranko-aha
Copy link

@ranko-aha ranko-aha commented Mar 5, 2025

What is the purpose of the change

Fix a typo in streaming analytics zh document.
Typo here https://nightlies.apache.org/flink/flink-docs-release-1.20/zh/docs/learn-flink/streaming_analytics/
This '时间' should be ‘数据’.
image

Brief change log

Fix a typo in streaming analytics zh document.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@ranko-aha ranko-aha changed the title [FLINK-37422][docs]Fix typo in streaming analytics zh document [FLINK-37422][docs] Fix typo in streaming analytics zh document Mar 5, 2025
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 5, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@@ -83,7 +83,7 @@ Flink 中事件时间的处理取决于 *watermark 生成器*,后者将带有
<a name="latency-vs-completeness"></a>
### 延迟 VS 正确性

watermarks 给了开发者流处理的一种选择,它们使开发人员在开发应用程序时可以控制延迟和完整性之间的权衡。与批处理不同,批处理中的奢侈之处在于可以在产生任何结果之前完全了解输入,而使用流式传输,我们不被允许等待所有的时间都产生了,才输出排序好的数据,这与流相违背。
watermarks 给了开发者流处理的一种选择,它们使开发人员在开发应用程序时可以控制延迟和完整性之间的权衡。与批处理不同,批处理中的奢侈之处在于可以在产生任何结果之前完全了解输入,而使用流式传输,我们不被允许等待所有的数据都产生了,才输出排序好的数据,这与流相违背。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From google translate the change it to wait for all the data from wait for all the time, which seems reasonable.

At the end of this line I notice:
The English:
with streaming you must eventually stop waiting to see more of the input, and produce some sort of result.
The Chinese:
we are not allowed to wait for all the data to be produced before outputting the sorted data, which is contrary to the flow.

Please could you review this piece of the changed line as well, as the meaning seems different to the English. This could be a quirk of google translate but saying you are not allowed to wait - is not the same as the English.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Google Translate does not fully express the meaning of Chinese. It should be translated like this。

we cannot wait until all the data has been generated before output the sorted data, as this would go against the principles of stream processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants