[hotfix] make previousCpuTicks and previousProcCpuTicks volatile to increase visibility for all threads #26257
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes a visibility issue in the
SystemResourcesCounter
class by markingpreviousCpuTicks
andpreviousProcCpuTicks
as volatile.Previously, these variables were not declared as volatile, meaning updates made by one thread might not be immediately visible to others. This could lead to stale values being read by different threads.
By making these variables volatile, we ensure that all threads see the most up-to-date values, preventing inconsistencies.
Brief change log
previousCpuTicks
andpreviousProcCpuTicks
as volatile to ensure proper visibility across threads.Verifying this change
This change is a trivial rework/code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts?
@Public(Evolving)
)? NoDocumentation