[FLINK-37431]We should use guava Lists instead of curator shade Lists…

[zlzhang0122]

What is the purpose of the change

• This pull request use guava Lists instead of curator shade Lists to avoid unnecessary error *

Brief change log

• Change curator Lists to guava Lists like other places

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[flinkbot]

CI report:

• cdab228 Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[davidradl]

We should use the non shaded version and get rid of shaded imports unless there is a really good reason to keep them. Other parts of the table planner use the non shaded version as an import.

[zlzhang0122]

We should use the non shaded version and get rid of shaded imports unless there is a really good reason to keep them. Other parts of the table planner use the non shaded version as an import.

ok, I have changed this and some other places which have the same problem.

[davidradl]

I notice the CI is failing with

03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowPropertiesRules.java:[33,1] (imports) IllegalImport: com.google.common.collect.Iterables; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowPropertiesRules.java:[34,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinDeriveNullFilterRule.java:[23,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/EventTimeTemporalJoinRewriteRule.java:[31,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecIntervalJoin.java:[60,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecJoin.java:[54,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecWindowJoin.java:[52,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/test/java/org/apache/flink/table/planner/plan/hints/batch/JoinHintTestBase.java:[34,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
0

It would be good to understand why we are using the shading - what more do we need to do to remove it.

[zlzhang0122]

I notice the CI is failing with

03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowPropertiesRules.java:[33,1] (imports) IllegalImport: com.google.common.collect.Iterables; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowPropertiesRules.java:[34,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinDeriveNullFilterRule.java:[23,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/rules/logical/EventTimeTemporalJoinRewriteRule.java:[31,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecIntervalJoin.java:[60,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecJoin.java:[54,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecWindowJoin.java:[52,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
03:33:57.572 [ERROR] src/test/java/org/apache/flink/table/planner/plan/hints/batch/JoinHintTestBase.java:[34,1] (imports) IllegalImport: com.google.common.collect.Lists; Use flink-shaded-guava instead.
0

It would be good to understand why we are using the shading - what more do we need to do to remove it.

IMO we should use the shaded jar version in case of jar version conflict, maybe we should change them to shading version to get rid of conflict between flink cluster jars and user jars, WDYT?