-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37298] Added Pluggable Components for BatchStrategy & BufferWrapper in AsyncSinkWriter. #26274
base: master
Are you sure you want to change the base?
[FLINK-37298] Added Pluggable Components for BatchStrategy & BufferWrapper in AsyncSinkWriter. #26274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, thanks for delivering this. Just a couple of questions and nits.
...rs/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/Batch.java
Show resolved
Hide resolved
...k-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BatchCreator.java
Show resolved
Hide resolved
...-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferWrapper.java
Show resolved
Hide resolved
...ctor-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTest.java
Show resolved
Hide resolved
...ector-base/src/main/java/org/apache/flink/connector/base/sink/writer/SimpleBatchCreator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good, thanks for the huge efforts
...-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferWrapper.java
Show resolved
Hide resolved
...-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/BufferWrapper.java
Outdated
Show resolved
Hide resolved
...onnector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
Show resolved
Hide resolved
...onnector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
Outdated
Show resolved
Hide resolved
could we have the docs change to publicise this change and advice on supplying pluggable strategies and BufferWrapper. |
Thanks for the suggestion! The JavaDocs for BatchCreator and BufferWrapper already document their purpose and usage. Regarding additional documentation changes since there's an ongoing vote on this FLIP, would it make sense to wait until finalized and then follow up with documentation updates in a separate PR? Let me know what you think—happy to adjust based on the preferred approach! :) |
8b97772
to
f3c3386
Compare
Hey @dannycranmer can you help with this review? |
What is the purpose of the change
FLIP-509
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation