-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37463] make serialzer in ForStMapState Threadlocal #26286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, LGTM.
It seems that the failure of EventTimeWindowCheckpointingITCase
is not related to this PR, as EventTimeWindowCheckpointingITCase
is using ForStSyncKeyedStateBackend
.
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, LGTM +1.
@flinkbot run azure |
@fredia I see that the single test |
A coredump occurred while running I reverted the integration of ForSt in |
2d1ceb0
to
10bc584
Compare
@flinkbot run azure |
@fredia |
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
What is the purpose of the change
Now, when using ForStMapState for asynchronous state reading and writing, userValueSerializer in ForStMapState will be used to serialize and deserialize the data. However, in asynchronous execution mode, multiple threads may use the same userValueSerializer instance for serialization and deserialization at the same time, which may cause some multi-thread conflicts in Serializer (eg: Kryo), so we need to make the userValueSerializer and userKeySerializer in ForStMapState ThreadLocal to avoid these problems.
Brief change log
make the userValueSerializer and userKeySerializer in ForStMapState ThreadLocal
Verifying this change
This change is a trivial rework
This change is already covered by existing tests
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation