-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix][docs] flink docs zh content fix #26294
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catching.
LGTM +1.
@RocMarshal When will my commit be merged into master? Do I still need other commiter reviews? |
@klion26 hi,could you please help me review this commit? |
@@ -180,7 +180,7 @@ Flink 有一些内置的窗口分配器,如下所示: | |||
以下都是一些可以使用的间隔时间 `Duration.ofMillis(n)`, `Duration.ofSeconds(n)`, `Duration.ofMinutes(n)`, | |||
`Duration.ofHours(n)`, 和 `Duration.ofDays(n)`。 | |||
|
|||
基于时间的窗口分配器(包括会话时间)既可以处理 `事件时间`,也可以处理 `处理时间`。这两种基于时间的处理没有哪一个更好,我们必须折衷。使用 `处理时间`,我们必须接受以下限制: | |||
基于时间的窗口分配器(包括会话时间)既可以处理 `事件时间`,也可以处理 `处理时间`。这两种基于时间的处理没有哪一个更好,我们必须折中。使用 `处理时间`,我们必须接受以下限制: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
google translate to english does not show any changes, but I see one character has changed. I assume the replacement is better Chinese grammatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the replacement is more widely used and more general
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huangyanyanyan thanks for the contribution, LGTM
flink docs zh content fix