Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding service labels to flink config #26301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jklaw90
Copy link

@jklaw90 jklaw90 commented Mar 14, 2025

What is the purpose of the change

Provide ability to set labels on services created by flink on the flinkdeployment spec.
https://issues.apache.org/jira/browse/FLINK-37478

Brief change log

  • updated config to include kubernetes.rest-service.labels and kubernetes.internal-service.labels to allow setting labels on services.

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

This change added tests and can be verified as follows:

  • Added unit tests for specifying label metadata on services.

Does this pull request potentially affect one of the following parts:

  • The serializers: yes
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 14, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@jklaw90 jklaw90 force-pushed the julian/service-labels branch from f8d702a to 946eb87 Compare March 15, 2025 05:03
@jklaw90
Copy link
Author

jklaw90 commented Mar 17, 2025

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants