Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37480][build] Bump japicmp to avoid false positives #26304

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

gaborgsomogyi
Copy link
Contributor

What is the purpose of the change

This limitation has been found during development of #26299.
Japicmp now gives false positive in case of generic templates:

[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.17.1:cmp (default) on project flink-state-processor-api: There is at least one incompatibility: org.apache.flink.state.api.OperatorTransformation.bootstrapWith(org.apache.flink.api.java.DataSet,long):CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.flink.state.api.OperatorTransformation.bootstrapWith(org.apache.flink.streaming.api.datastream.DataStream,long):CLASS_GENERIC_TEMPLATE_CHANGED -> [Help 1]

The problem is caused by siom79/japicmp#368. In this PR I've bumped japicmp to the minimum version where this has been resolved.

Brief change log

Bumped japicmp version.

Verifying this change

Manually during compile.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@gaborgsomogyi
Copy link
Contributor Author

cc @Zakelly

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 17, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaborgsomogyi gaborgsomogyi merged commit f3d9681 into apache:master Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants