-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37475] Drop ChangelogNormalize for piping from upsert source to sink #26306
base: master
Are you sure you want to change the base?
Conversation
3f18260
to
2eb62e6
Compare
…o sink * Add information about DELETE to ChangelogMode * Adapt FlinkChangelogModeInferenceProgram to remove ChangelogNormalize if possible
@@ -155,7 +156,11 @@ class TestName extends BeforeEachCallback { | |||
} | |||
methodName = s"${context.getTestMethod.get().getName}$displayName" | |||
} else { | |||
methodName = context.getTestMethod.get().getName | |||
if (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[ParameterizedTest])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[ParameterizedTest])) { | |
if (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[ParameterizedTest]) | |
|| (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[TestTemplate])) { |
May be also include TestTemplate
?
// no ChangeLogNormalize | ||
public static final TableTestProgram INSERT_SELECT_DELETE_ON_KEY_DELETE_ON_KEY = | ||
TableTestProgram.of( | ||
"select-delete-on-key-to-delete-on-key", | ||
"validates results when querying source with deletes on key" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// no ChangeLogNormalize | |
public static final TableTestProgram INSERT_SELECT_DELETE_ON_KEY_DELETE_ON_KEY = | |
TableTestProgram.of( | |
"select-delete-on-key-to-delete-on-key", | |
"validates results when querying source with deletes on key" | |
public static final TableTestProgram INSERT_SELECT_DELETE_ON_KEY_DELETE_ON_KEY = | |
TableTestProgram.of( | |
"select-delete-on-key-to-delete-on-key", | |
"No ChangeLogNormalize: validates results when querying source with deletes on key" |
How about including this into description instead of a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only a couple of minor comments
What is the purpose of the change
Remove ChangelogNormalize if possible for
INSERT INTO SELECT * FROM
Verifying this change
Added plan and semantic tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation