Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-37475] Drop ChangelogNormalize for piping from upsert source to sink #26306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-37475] Drop ChangelogNormalize for piping from upsert source to sink #26306

wants to merge 1 commit into from
+1,641 −51

Conversation

dawidwys
Copy link
Contributor

What is the purpose of the change

Remove ChangelogNormalize if possible for INSERT INTO SELECT * FROM

Verifying this change

Added plan and semantic tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@dawidwys dawidwys marked this pull request as draft March 17, 2025 08:11
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 17, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dawidwys dawidwys force-pushed the flink37475 branch 3 times, most recently from 3f18260 to 2eb62e6 Compare March 17, 2025 17:25
@dawidwys
[FLINK-37475] Drop ChangelogNormalize for piping from upsert source t…
eb97525 
…o sink

* Add information about DELETE to ChangelogMode
* Adapt FlinkChangelogModeInferenceProgram to remove ChangelogNormalize
  if possible
@dawidwys dawidwys marked this pull request as ready for review March 18, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=TableSQL/API component=TableSQL/Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawidwys @flinkbot