Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37475] Drop ChangelogNormalize for piping from upsert source to sink #26306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dawidwys
Copy link
Contributor

What is the purpose of the change

Remove ChangelogNormalize if possible for INSERT INTO SELECT * FROM

Verifying this change

Added plan and semantic tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@dawidwys dawidwys marked this pull request as draft March 17, 2025 08:11
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 17, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…o sink

* Add information about DELETE to ChangelogMode
* Adapt FlinkChangelogModeInferenceProgram to remove ChangelogNormalize
  if possible
@dawidwys dawidwys marked this pull request as ready for review March 18, 2025 07:26
@@ -155,7 +156,11 @@ class TestName extends BeforeEachCallback {
}
methodName = s"${context.getTestMethod.get().getName}$displayName"
} else {
methodName = context.getTestMethod.get().getName
if (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[ParameterizedTest])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[ParameterizedTest])) {
if (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[ParameterizedTest])
|| (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[TestTemplate])) {

May be also include TestTemplate ?

Comment on lines +37 to +41
// no ChangeLogNormalize
public static final TableTestProgram INSERT_SELECT_DELETE_ON_KEY_DELETE_ON_KEY =
TableTestProgram.of(
"select-delete-on-key-to-delete-on-key",
"validates results when querying source with deletes on key"
Copy link
Contributor

@snuyanzin snuyanzin Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// no ChangeLogNormalize
public static final TableTestProgram INSERT_SELECT_DELETE_ON_KEY_DELETE_ON_KEY =
TableTestProgram.of(
"select-delete-on-key-to-delete-on-key",
"validates results when querying source with deletes on key"
public static final TableTestProgram INSERT_SELECT_DELETE_ON_KEY_DELETE_ON_KEY =
TableTestProgram.of(
"select-delete-on-key-to-delete-on-key",
"No ChangeLogNormalize: validates results when querying source with deletes on key"

How about including this into description instead of a comment?

Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only a couple of minor comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants