[FLINK-37475] Drop ChangelogNormalize for piping from upsert source to sink #26306
+1,641
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidwys
force-pushed
the
flink37475
branch
3 times, most recently
from
3f18260 to
2eb62e6
Compare
…o sink * Add information about DELETE to ChangelogMode * Adapt FlinkChangelogModeInferenceProgram to remove ChangelogNormalize if possible
snuyanzin
reviewed
Mar 18, 2025
| @@ -155,7 +156,11 @@ class TestName extends BeforeEachCallback { | |||
| } | |||
| methodName = s"${context.getTestMethod.get().getName}$displayName" | |||
| } else { | |||
| methodName = context.getTestMethod.get().getName | |||
| if (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[ParameterizedTest])) { | |||
There was a problem hiding this comment.
Suggested change
| if (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[ParameterizedTest])) { | |
| if (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[ParameterizedTest]) | |
| || (AnnotationSupport.isAnnotated(context.getTestMethod, classOf[TestTemplate])) { |
May be also include TestTemplate ?
snuyanzin
reviewed
Mar 18, 2025
Comment on lines
+37
to
+41
| // no ChangeLogNormalize | ||
| public static final TableTestProgram INSERT_SELECT_DELETE_ON_KEY_DELETE_ON_KEY = | ||
| TableTestProgram.of( | ||
| "select-delete-on-key-to-delete-on-key", | ||
| "validates results when querying source with deletes on key" |
There was a problem hiding this comment.
Suggested change
| // no ChangeLogNormalize | |
| public static final TableTestProgram INSERT_SELECT_DELETE_ON_KEY_DELETE_ON_KEY = | |
| TableTestProgram.of( | |
| "select-delete-on-key-to-delete-on-key", | |
| "validates results when querying source with deletes on key" | |
| public static final TableTestProgram INSERT_SELECT_DELETE_ON_KEY_DELETE_ON_KEY = | |
| TableTestProgram.of( | |
| "select-delete-on-key-to-delete-on-key", | |
| "No ChangeLogNormalize: validates results when querying source with deletes on key" |
How about including this into description instead of a comment?
snuyanzin
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Remove ChangelogNormalize if possible for
INSERT INTO SELECT * FROMVerifying this change
Added plan and semantic tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation