Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37412] Add MIN_RESOURCES TaskManagerLoadBalanceMode to maximize TM usage #26308

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

vahmed-hamdy
Copy link
Contributor

What is the purpose of the change

  • Add RESOURCES allocation strategy to maximize usage of allocated TMs before using another one.

Brief change log

  • Added new configuration value RESOURCES for TaskManagerLoadBalanceMode.
  • Added mostUtilization allocation strategy to DefaultResourceAllocationStrategy

Verifying this change

  • Added relevant UTs

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? NA

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 17, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @vahmed-hamdy . The change looks good. I added a few minor comments. PTAL

@vahmed-hamdy vahmed-hamdy changed the title [FLINK-37412] Add RESOURCES TaskManagerLoadBalanceMode to maximize TM usage [FLINK-37412] Add MIN_RESOURCES TaskManagerLoadBalanceMode to maximize TM usage Mar 17, 2025
@airlock-confluentinc airlock-confluentinc bot force-pushed the FLINK-37412 branch 2 times, most recently from 93eaa99 to 2b9d4cb Compare March 17, 2025 14:16
@vahmed-hamdy vahmed-hamdy requested a review from XComp March 17, 2025 14:16
@vahmed-hamdy
Copy link
Contributor Author

@XComp @Poorvankbhatia @RocMarshal thanks all for the review, please have another look if possible

Copy link

@Poorvankbhatia Poorvankbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up :)

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 One final comment which we could consider.

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updating.
LGTM +1 👍

@XComp XComp merged commit 034d19c into apache:master Mar 19, 2025
@XComp XComp deleted the FLINK-37412 branch March 19, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants