-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37412] Add MIN_RESOURCES TaskManagerLoadBalanceMode to maximize TM usage #26308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @vahmed-hamdy . The change looks good. I added a few minor comments. PTAL
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
Show resolved
Hide resolved
.../org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
Outdated
Show resolved
Hide resolved
.../apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategyTest.java
Outdated
Show resolved
Hide resolved
.../apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategyTest.java
Show resolved
Hide resolved
93eaa99
to
2b9d4cb
Compare
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
Show resolved
Hide resolved
.../org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java
Show resolved
Hide resolved
.../org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
Outdated
Show resolved
Hide resolved
2b9d4cb
to
b9b2c93
Compare
@XComp @Poorvankbhatia @RocMarshal thanks all for the review, please have another look if possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this up :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 One final comment which we could consider.
.../apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategyTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updating.
LGTM +1 👍
b9b2c93
to
560daea
Compare
What is the purpose of the change
RESOURCES
allocation strategy to maximize usage of allocated TMs before using another one.Brief change log
RESOURCES
forTaskManagerLoadBalanceMode
.mostUtilization
allocation strategy toDefaultResourceAllocationStrategy
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation