[FLINK-37570][metrics] Export default watermark if split doesn't have any #26356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowojski
changed the title
pnowojski
requested changes
Mar 27, 2025
...me/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSourceSplitMetricGroup.java
Outdated
Show resolved
Hide resolved
davidradl
reviewed
Mar 27, 2025
flink-runtime/src/test/java/org/apache/flink/streaming/api/operators/SourceOperatorTest.java
Show resolved
Hide resolved
Efrat19
force-pushed
the
FLINK-37410-followup
branch
from
0bb6bc3 to
65d77aa
Compare
davidradl
approved these changes
Mar 27, 2025
Efrat19
force-pushed
the
FLINK-37410-followup
branch
from
65d77aa to
4a26507
Compare
Efrat19
force-pushed
the
FLINK-37410-followup
branch
2 times, most recently
from
13061fb to
19488d1
Compare
Efrat19
force-pushed
the
FLINK-37410-followup
branch
from
19488d1 to
586299e
Compare
pnowojski
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #26276
Accounting for splits that have no watermarks assigned to them