Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Azure image support #436

Merged

Conversation

arvindshmicrosoft
Copy link
Member

  • Add support for specifying image payment plans when creating VMs or VMSS. This allows using certain images which require payment plan information. For example, the Rocky Linux image in Azure requires a plan name to be provided, even though that plan is the "free" plan.
  • Add support for using custom Azure images with Muchos.
  • Make the cloud-init file name configurable.
  • Add optional parameters for the proxy image configuration (image name, payment plan, cloud-init filename).
  • Allow specifying the OS disk size for Azure VMs.
  • Remove the deprecated warn attribute when using the shell module.

* Add support for specifying image payment plans when creating VMs or VMSS.
  This allows using certain images which require payment plan information.
  For example, the Rocky Linux image in Azure requires a plan name to be
  provided, even though that plan is the "free" plan.
* Add support for using custom Azure images with Muchos.
* Make the cloud-init file name configurable.
* Add optional parameters for the proxy image configuration (image name,
  payment plan, cloud-init filename).
* Allow specifying the OS disk size for Azure VMs.
* Remove the deprecated `warn` attribute when using the `shell` module.
Copy link
Member

@brianloss brianloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but saw one typo

docs/azure-image-reference.md Outdated Show resolved Hide resolved
Co-authored-by: Brian Loss <[email protected]>
@arvindshmicrosoft arvindshmicrosoft merged commit 883a041 into apache:main Nov 13, 2023
2 checks passed
@arvindshmicrosoft arvindshmicrosoft deleted the improve-azure-image-support branch November 13, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants