feat(JavaScript): Support ESM #1347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theweipeng
changed the title
bytemain
suggested changes
Jan 19, 2024
javascript/benchmark/index.mjs
Outdated
| import { fileURLToPath } from 'url'; | ||
| import { spawn } from 'child_process'; | ||
|
|
||
| const fury = new Fury.default({ hps: Hps, refTracking: false, useSliceString: true }); |
There was a problem hiding this comment.
if we use esm format, here we can remove this default
| "module": "dist/esm/index.js", | ||
| "scripts": { | ||
| "build": "tsc", | ||
| "build": "tsc -p tsconfig.json && tsc -p tsconfig.esm.json", |
There was a problem hiding this comment.
this may produce two typings, and we indeed need one.
we can set declaration: false in the tsconfig.esm.json, and use:
"declaration": true,
"declarationDir": "types"
in the tsconfig.json.
finally, set "types": "types/index.d.ts" in package.json
theweipeng
force-pushed
the
support_esm
branch
from
a3c73de to
d6e300a
Compare
|
@chaokunyang Is this OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESM is the next-generation module system for javascript. We should support it.