Skip to content

Conversation

LiangliangSui
Copy link
Contributor

What does this PR do?

Related issues

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

buffer.writeByte(NOT_NULL_VALUE_FLAG);
writeNonRef(buffer, obj);
}
fory.writeNullable(buffer, obj);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually inline have better performance. JVM JIT nto always inline those calls

@LiangliangSui
Copy link
Contributor Author

Does readNullable also need to be manually inline?

@Override
public Object readNullable(MemoryBuffer buffer, Serializer<Object> serializer) {
return fory.xreadNullable(buffer, serializer);
}

@chaokunyang
Copy link
Collaborator

Does readNullable also need to be manually inline?

@Override
public Object readNullable(MemoryBuffer buffer, Serializer<Object> serializer) {
return fory.xreadNullable(buffer, serializer);
}

Yes, we'd better do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants