Skip to content

fix: Correct pyarrow installation check and add bazel troubleshooting #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

esafak
Copy link
Contributor

@esafak esafak commented Jul 15, 2025

I made a mistake in #2396 when I changed

func = pytest.mark.fory_format(func)
arrow_installed = False
if pa is not None and hasattr(pa, "get_library_dirs"):
    arrow_installed = True
func = pytest.mark.skipif(not arrow_installed, reason="pyarrow not installed")(func)
return func

to

arrow_not_installed = pa is None or hasattr(pa, "get_library_dirs")
mark_decorator = pytest.mark.skipif(arrow_not_installed, reason="pyarrow not installed")(func)
return mark_decorator

The second condition, hasattr(pa, "get_library_dirs"), should have been negated. I noticed this when arrow tests were incorrectly being skipped :|

What does this PR do?

  • Fix incorrect pyarrow installation check in core.py
  • Add troubleshooting steps for bazel caching issues in README.md

* Fix incorrect pyarrow installation check in core.py
* Add troubleshooting steps for bazel caching issues in README.md
@esafak esafak requested a review from chaokunyang as a code owner July 15, 2025 16:03
@chaokunyang chaokunyang merged commit f26681c into apache:main Jul 16, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants