Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(C#): add C# implementation (WIP) #2004

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
3b65665
init commit
Handsome-cong Dec 26, 2024
82d1534
add deserialize api
Handsome-cong Dec 26, 2024
27d5d2f
add varint32/varint64 support
Handsome-cong Dec 27, 2024
ae1136e
add comments for Unbox
Handsome-cong Dec 27, 2024
7beb2d8
rename RefResolver to RefRegistration
Handsome-cong Dec 28, 2024
8306318
remove broken unit test
Handsome-cong Dec 28, 2024
85edc94
add MurmurHash3 algorithm implementation
Handsome-cong Dec 29, 2024
fda18a2
add pooled list
Handsome-cong Dec 30, 2024
3a18c60
add MemberNotNullAttribute
Handsome-cong Dec 30, 2024
166e801
add ShardArrayPoolProvider
Handsome-cong Dec 30, 2024
11be959
improve PooledList
Handsome-cong Dec 30, 2024
7d58685
replace List with PooledList
Handsome-cong Dec 30, 2024
aee3c72
improve ObjectPool & PooledList
Handsome-cong Dec 30, 2024
d5c8d80
remove extensions
Handsome-cong Dec 30, 2024
907c8db
Merge branch 'apache:main' into csharp_impl
Handsome-cong Dec 30, 2024
eea0623
Merge remote-tracking branch 'origin/csharp_impl' into csharp_impl
Handsome-cong Dec 30, 2024
9a9b702
avoid use pointer to create string
Handsome-cong Dec 31, 2024
45e8b26
Add MetaString and encodings
Handsome-cong Dec 31, 2024
c39fc91
remove redundant fields & CanEncode method
Handsome-cong Jan 1, 2025
24522c6
make element type of PooledList nullable
Handsome-cong Jan 6, 2025
3912427
add meta string encoding
Handsome-cong Jan 12, 2025
87ae8b9
Merge branch 'apache:main' into csharp_impl
Handsome-cong Jan 12, 2025
b55e7a4
remove unnecessary using
Handsome-cong Jan 12, 2025
5cd3605
improve BitUtility.cs
Handsome-cong Jan 13, 2025
613ffc1
refactor exception throwing
Handsome-cong Jan 13, 2025
580ebd6
format code
Handsome-cong Jan 13, 2025
b774e4a
remove dependency on Moq
Handsome-cong Jan 13, 2025
3d71f8d
Merge branch 'apache:main' into csharp_impl
Handsome-cong Jan 13, 2025
b3e2763
make Box readonly
Handsome-cong Jan 13, 2025
6593ec4
remove meaningless check in PooledList
Handsome-cong Jan 13, 2025
3ab8a73
Merge remote-tracking branch 'origin/csharp_impl' into csharp_impl
Handsome-cong Jan 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,5 @@ MODULE.bazel
MODULE.bazel.lock
.DS_Store
**/.DS_Store
csharp/**/bin
csharp/**/obj
1 change: 1 addition & 0 deletions csharp/.csharpierrc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
printWidth: 120
36 changes: 36 additions & 0 deletions csharp/Fury.Testing/Fakes/SinglePrimitiveFieldObject.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
using Fury.Serializer;

namespace Fury.Testing.Fakes;

public sealed class SinglePrimitiveFieldObject
{
public int Value { get; set; }

public sealed class Serializer : AbstractSerializer<SinglePrimitiveFieldObject>
{
public override void Write(SerializationContext context, in SinglePrimitiveFieldObject value)
{
context.Writer.Write(value.Value);
}
}

public sealed class Deserializer : AbstractDeserializer<SinglePrimitiveFieldObject>
{
public override ValueTask<Box<SinglePrimitiveFieldObject>> CreateInstanceAsync(
DeserializationContext context,
CancellationToken cancellationToken = default
)
{
return new ValueTask<Box<SinglePrimitiveFieldObject>>(new SinglePrimitiveFieldObject());
}

public override async ValueTask ReadAndFillAsync(
DeserializationContext context,
Box<SinglePrimitiveFieldObject> instance,
CancellationToken cancellationToken = default
)
{
instance.Value!.Value = await context.Reader.ReadAsync<int>(cancellationToken);
}
}
}
29 changes: 29 additions & 0 deletions csharp/Fury.Testing/Fury.Testing.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<!-- <TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>-->
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<LangVersion>12</LangVersion>
<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Bogus" Version="35.6.1" />
<PackageReference Include="coverlet.collector" Version="6.0.0"/>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0"/>
<PackageReference Include="xunit" Version="2.5.3"/>
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.3"/>
</ItemGroup>

<ItemGroup>
<Using Include="Xunit"/>
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\Fury\Fury.csproj" />
</ItemGroup>

</Project>
252 changes: 252 additions & 0 deletions csharp/Fury.Testing/MetaStringTest.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,252 @@
using System.Text;
using Bogus;
using Fury.Meta;

namespace Fury.Testing;

public sealed class MetaStringTest
{
public static readonly IEnumerable<object[]> Lengths = Enumerable.Range(0, 9).Select(i => new object[] { i });

private static readonly string LowerSpecialChars = Enumerable
.Range(0, 1 << AbstractLowerSpecialEncoding.BitsPerChar)
.Select(i => (AbstractLowerSpecialEncoding.TryDecodeByte((byte)i, out var c), c))
.Where(t => t.Item1)
.Aggregate(new StringBuilder(), (builder, t) => builder.Append(t.c))
.ToString();

private static readonly string AllToLowerSpecialChars = Enumerable
.Range(0, 1 << AbstractLowerSpecialEncoding.BitsPerChar)
.Select(i => (AbstractLowerSpecialEncoding.TryDecodeByte((byte)i, out var c), c))
.Where(t => t.Item1 && t.c != AllToLowerSpecialEncoding.UpperCaseFlag)
.Aggregate(new StringBuilder(), (builder, t) => builder.Append(t.c).Append(char.ToUpperInvariant(t.c)))
.ToString();

private static readonly string TypeNameLowerUpperDigitSpecialChars = Enumerable
.Range(0, 1 << LowerUpperDigitSpecialEncoding.BitsPerChar)
.Select(i => (Encodings.TypeNameEncoding.LowerUpperDigit.TryDecodeByte((byte)i, out var c), c))
.Where(t => t.Item1 && char.IsLetterOrDigit(t.c))
.Aggregate(new StringBuilder(), (builder, t) => builder.Append(t.c))
.ToString();

private static readonly string NamespaceLowerUpperDigitSpecialChars = Enumerable
.Range(0, 1 << LowerUpperDigitSpecialEncoding.BitsPerChar)
.Select(i => (Encodings.NamespaceEncoding.LowerUpperDigit.TryDecodeByte((byte)i, out var c), c))
.Where(t => t.Item1 && char.IsLetterOrDigit(t.c))
.Aggregate(new StringBuilder(), (builder, t) => builder.Append(t.c))
.ToString();

[Theory]
[MemberData(nameof(Lengths))]
public void LowerSpecialEncoding_InputString_ShouldReturnTheSame(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, LowerSpecialChars);

var bufferLength = LowerSpecialEncoding.Instance.GetByteCount(stubString);
Span<byte> buffer = stackalloc byte[bufferLength];
LowerSpecialEncoding.Instance.GetBytes(stubString, buffer);
var output = LowerSpecialEncoding.Instance.GetString(buffer);

Assert.Equal(stubString, output);
}

[Theory]
[MemberData(nameof(Lengths))]
public void LowerSpecialEncoding_InputSeparatedBytes_ShouldReturnConcatenatedString(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, LowerSpecialChars);

var bufferLength = LowerSpecialEncoding.Instance.GetByteCount(stubString);
Span<byte> bytes = stackalloc byte[bufferLength];
Span<char> chars = stackalloc char[stubString.Length];
LowerSpecialEncoding.Instance.GetBytes(stubString, bytes);
var decoder = LowerSpecialEncoding.Instance.GetDecoder();
var emptyChars = chars;
for (var i = 0; i < bytes.Length; i++)
{
var slicedBytes = bytes.Slice(i, 1);
decoder.Convert(slicedBytes, emptyChars, i == bytes.Length - 1, out _, out var charsUsed, out _);
emptyChars = emptyChars.Slice(charsUsed);
}

var output = chars.ToString();

Assert.Equal(stubString, output);
}

[Theory]
[MemberData(nameof(Lengths))]
public void FirstToLowerSpecialEncoding_InputString_ShouldReturnTheSame(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, LowerSpecialChars);
if (stubString.Length > 0 && char.IsLower(stubString[0]))
{
Span<char> stubSpan = stackalloc char[stubString.Length];
stubString.AsSpan().CopyTo(stubSpan);
stubSpan[0] = char.ToUpperInvariant(stubSpan[0]);
stubString = stubSpan.ToString();
}

var bufferLength = FirstToLowerSpecialEncoding.Instance.GetByteCount(stubString);
Span<byte> buffer = stackalloc byte[bufferLength];
FirstToLowerSpecialEncoding.Instance.GetBytes(stubString, buffer);
var output = FirstToLowerSpecialEncoding.Instance.GetString(buffer);

Assert.Equal(stubString, output);
}

[Theory]
[MemberData(nameof(Lengths))]
public void FirstToLowerSpecialEncoding_InputSeparatedBytes_ShouldReturnConcatenatedString(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, LowerSpecialChars);
if (stubString.Length > 0 && char.IsLower(stubString[0]))
{
Span<char> stubSpan = stackalloc char[stubString.Length];
stubString.AsSpan().CopyTo(stubSpan);
stubSpan[0] = char.ToUpperInvariant(stubSpan[0]);
stubString = stubSpan.ToString();
}

var bufferLength = FirstToLowerSpecialEncoding.Instance.GetByteCount(stubString);
Span<byte> bytes = stackalloc byte[bufferLength];
Span<char> chars = stackalloc char[stubString.Length];
FirstToLowerSpecialEncoding.Instance.GetBytes(stubString, bytes);
var decoder = FirstToLowerSpecialEncoding.Instance.GetDecoder();
var emptyChars = chars;
for (var i = 0; i < bytes.Length; i++)
{
var slicedBytes = bytes.Slice(i, 1);
decoder.Convert(slicedBytes, emptyChars, i == bytes.Length - 1, out _, out var charsUsed, out _);
emptyChars = emptyChars.Slice(charsUsed);
}

var output = chars.ToString();

Assert.Equal(stubString, output);
}

[Theory]
[MemberData(nameof(Lengths))]
public void AllToLowerSpecialEncoding_InputString_ShouldReturnTheSame(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, AllToLowerSpecialChars);

var bufferLength = AllToLowerSpecialEncoding.Instance.GetByteCount(stubString);
Span<byte> buffer = stackalloc byte[bufferLength];
AllToLowerSpecialEncoding.Instance.GetBytes(stubString, buffer);
var output = AllToLowerSpecialEncoding.Instance.GetString(buffer);

Assert.Equal(stubString, output);
}

[Theory]
[MemberData(nameof(Lengths))]
public void AllToLowerSpecialEncoding_InputSeparatedBytes_ShouldReturnConcatenatedString(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, AllToLowerSpecialChars);

var bufferLength = AllToLowerSpecialEncoding.Instance.GetByteCount(stubString);
Span<byte> bytes = stackalloc byte[bufferLength];
Span<char> chars = stackalloc char[stubString.Length];
AllToLowerSpecialEncoding.Instance.GetBytes(stubString, bytes);
var decoder = AllToLowerSpecialEncoding.Instance.GetDecoder();
var emptyChars = chars;
for (var i = 0; i < bytes.Length; i++)
{
var slicedBytes = bytes.Slice(i, 1);
decoder.Convert(slicedBytes, emptyChars, i == bytes.Length - 1, out _, out var charsUsed, out _);
emptyChars = emptyChars.Slice(charsUsed);
}

var output = chars.ToString();

Assert.Equal(stubString, output);
}

[Theory]
[MemberData(nameof(Lengths))]
public void TypeNameLowerUpperDigitSpecialEncoding_InputString_ShouldReturnTheSame(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, TypeNameLowerUpperDigitSpecialChars);

var bufferLength = Encodings.TypeNameEncoding.LowerUpperDigit.GetByteCount(stubString);
Span<byte> buffer = stackalloc byte[bufferLength];
Encodings.TypeNameEncoding.LowerUpperDigit.GetBytes(stubString, buffer);
var output = Encodings.TypeNameEncoding.LowerUpperDigit.GetString(buffer);

Assert.Equal(stubString, output);
}

[Theory]
[MemberData(nameof(Lengths))]
public void TypeNameLowerUpperDigitSpecialEncoding_InputSeparatedBytes_ShouldReturnConcatenatedString(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, TypeNameLowerUpperDigitSpecialChars);

var bufferLength = Encodings.TypeNameEncoding.LowerUpperDigit.GetByteCount(stubString);
Span<byte> bytes = stackalloc byte[bufferLength];
Span<char> chars = stackalloc char[stubString.Length];
Encodings.TypeNameEncoding.LowerUpperDigit.GetBytes(stubString, bytes);
var decoder = Encodings.TypeNameEncoding.LowerUpperDigit.GetDecoder();
var emptyChars = chars;
for (var i = 0; i < bytes.Length; i++)
{
var slicedBytes = bytes.Slice(i, 1);
decoder.Convert(slicedBytes, emptyChars, i == bytes.Length - 1, out _, out var charsUsed, out _);
emptyChars = emptyChars.Slice(charsUsed);
}

var output = chars.ToString();

Assert.Equal(stubString, output);
}

[Theory]
[MemberData(nameof(Lengths))]
public void NamespaceLowerUpperDigitSpecialEncoding_InputString_ShouldReturnTheSame(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, NamespaceLowerUpperDigitSpecialChars);

var bufferLength = Encodings.NamespaceEncoding.LowerUpperDigit.GetByteCount(stubString);
Span<byte> buffer = stackalloc byte[bufferLength];
Encodings.NamespaceEncoding.LowerUpperDigit.GetBytes(stubString, buffer);
var output = Encodings.NamespaceEncoding.LowerUpperDigit.GetString(buffer);

Assert.Equal(stubString, output);
}

[Theory]
[MemberData(nameof(Lengths))]
public void NamespaceLowerUpperDigitSpecialEncoding_InputSeparatedBytes_ShouldReturnConcatenatedString(int length)
{
var faker = new Faker();
var stubString = faker.Random.String2(length, NamespaceLowerUpperDigitSpecialChars);

var bufferLength = Encodings.NamespaceEncoding.LowerUpperDigit.GetByteCount(stubString);
Span<byte> bytes = stackalloc byte[bufferLength];
Span<char> chars = stackalloc char[stubString.Length];
Encodings.NamespaceEncoding.LowerUpperDigit.GetBytes(stubString, bytes);
var decoder = Encodings.NamespaceEncoding.LowerUpperDigit.GetDecoder();
var emptyChars = chars;
for (var i = 0; i < bytes.Length; i++)
{
var slicedBytes = bytes.Slice(i, 1);
decoder.Convert(slicedBytes, emptyChars, i == bytes.Length - 1, out _, out var charsUsed, out _);
emptyChars = emptyChars.Slice(charsUsed);
}

var output = chars.ToString();

Assert.Equal(stubString, output);
}
}
8 changes: 8 additions & 0 deletions csharp/Fury.slnx
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<Solution>
<Configurations>
<BuildType Name="Debug" />
<BuildType Name="Release" />
</Configurations>
<Project Path="Fury.Testing\Fury.Testing.csproj" Type="Classic C#" />
<Project Path="Fury\Fury.csproj" Type="Classic C#" />
</Solution>
21 changes: 21 additions & 0 deletions csharp/Fury/Backports/BitOperations.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#if !NET8_0_OR_GREATER
using System.Runtime.CompilerServices;

// ReSharper disable once CheckNamespace
namespace System.Numerics;

internal static class BitOperations
{
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static ulong RotateLeft(ulong value, int offset) => (value << offset) | (value >> (64 - offset));

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static uint RotateLeft(uint value, int offset) => (value << offset) | (value >> (32 - offset));

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static ulong RotateRight(ulong value, int offset) => (value >> offset) | (value << (64 - offset));

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static uint RotateRight(uint value, int offset) => (value >> offset) | (value << (32 - offset));
}
#endif
7 changes: 7 additions & 0 deletions csharp/Fury/Backports/NotReturnAttributes.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#if !NET8_0_OR_GREATER
// ReSharper disable once CheckNamespace
namespace System.Diagnostics.CodeAnalysis;

[AttributeUsage(AttributeTargets.Method, Inherited = false)]
internal class DoesNotReturnAttribute : Attribute;
#endif
Loading
Loading