Skip to content

[Runtime] Fix checkpoint causing empty results in PipelineServiceExecutorContext (#543) #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

huhao0926
Copy link
Contributor

@huhao0926 huhao0926 commented Jun 28, 2025

  • fix checkpoint causing empty results in interactive query
  • skip checkpoint when context is PipelineServiceExecutorContext

What changes were proposed in this pull request?

How was this PR tested?

STEP1:
start the task and execute following gql:
"""
MATCH (a:person) -[e ]->(b)
Let a.out_cnt = COUNT((b) ->(c) => c),
Let b.out_weight = SUM((b) -[e1]-> (c) => e1.weight)
RETURN a,e,b
"""
You can see that the query results is not empty

STEP2:
execute
"""
WITH p AS (
SELECT * FROM (VALUES(1, 0.4), (4, 0.5)) AS t(id, weight)
)
MATCH (a:person where a.id = p.id) -[e where weight < p.weight + 0.1]->(b)
Let a.out_cnt = COUNT((b) ->(c) => c),
Let b.out_weight = SUM((b) -[e1]-> (c) => e1.weight)
RETURN a,e,b
"""
You can also see that the query results is not empty

STEP3:
execute gsql the same as step1 or step2
"""
MATCH (a:person) -[e ]->(b)
Let a.out_cnt = COUNT((b) ->(c) => c),
Let b.out_weight = SUM((b) -[e1]-> (c) => e1.weight)
RETURN a,e,b
"""
Before:
the results is empty

After integrating repair PR:
consistent with the previous query results

…utorContext (apache#543)

* fix checkpoint causing empty results in interactive query
* skip checkpoint when context is PipelineServiceExecutorContext
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2025

CLA assistant check
All committers have signed the CLA.

@huhao0926
Copy link
Contributor Author

CLA assistant check All committers have signed the CLA.

I have agreed to the CLA for TuGraph-family/tugraph-analytics

@cbqiao
Copy link
Contributor

cbqiao commented Jul 1, 2025

LGTM

@Loognqiang Loognqiang requested a review from cbqiao July 1, 2025 12:25
Copy link
Contributor

@Loognqiang Loognqiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Loognqiang Loognqiang merged commit fae74b3 into apache:master Jul 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants