Skip to content

[Cluster] Fix BRPC endpoint conflict in local multi-container deployment #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025

Conversation

huhao0926
Copy link
Contributor

…ent (#547)

  • Fix BRPC endpoint registration conflict when launching multiple containers in local mode
  • Add geaflow.executor.thread.max.multiple configuration for thread pool scaling

What changes were proposed in this pull request?

How was this PR tested?

Verification Steps:

  1. Test local mode with multiple containers (geaflow.container.num=3):

    • Expected: Fails with IllegalArgumentException "local mode containerNum must equal with 1"
  2. Test with excessive worker threads (geaflow.container.worker.num=170):

    • Expected: Fails with IllegalArgumentException "executor threads should be smaller than 60"
  3. Test with proper config (geaflow.executor.thread.max.multiple=50):

    • Expected: Runs successfully with completion message "source already finished"

huhao0926 added 4 commits July 9, 2025 08:47
…ent (apache#547)

* Fix BRPC endpoint registration conflict when launching multiple containers in local mode
* Add geaflow.executor.thread.max.multiple configuration for thread pool scaling
@huhao0926 huhao0926 changed the title [Cluster] Fix BRPC endpoint conflict in local multi-container deploym… [Cluster] Fix BRPC endpoint conflict in local multi-container deployment Jul 9, 2025
Copy link
Contributor

@cbqiao cbqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Loognqiang Loognqiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Loognqiang Loognqiang merged commit 415f00b into apache:master Jul 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants