-
-
Notifications
You must be signed in to change notification settings - Fork 961
Update grails-shell-cli to use org.apache.grails.profiles coordinates #14683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…g.apache.grails.profiles group
@@ -85,7 +85,7 @@ class GrailsCreateStartScripts extends CreateStartScripts { | |||
generator.classpath = projectArtifacts + getClasspath().resolvedConfiguration.resolvedArtifacts.collect { artifact -> | |||
def dependency = artifact.moduleVersion.id | |||
String installedFile = "lib/$dependency.group/$dependency.name/jars/$artifact.file.name" | |||
if (dependency.group.startsWith('org.apache.grails') && !project.file(installedFile).exists()) { | |||
if (dependency.group.startsWith('org.apache.grails') && dependency.name != 'grails-gradle-model' && !project.file(installedFile).exists()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add this comment here:
// TODO: consider includedBuilds as artifacts by iterating over gradle.includedBuilds.projectDir to find included build artifacts
@@ -58,6 +58,8 @@ A list of Maven repositories to include in the generated build. Example: | |||
[source,yaml] | |||
---- | |||
repositories: | |||
- "https://repo1.maven.org/maven2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be a property that we include one or the other based on if it's a snapshot build
@@ -65,6 +65,8 @@ class GrailsDependencyVersions implements DependencyManagement { | |||
|
|||
static GrapeEngine getDefaultEngine() { | |||
def grape = Grape.getInstance() | |||
grape.addResolver([name:"mavenCentral", root:"https://repo1.maven.org/maven2"] as Map<String, Object>) | |||
grape.addResolver([name:"apacheSnapshot", root:"https://repository.apache.org/content/groups/snapshots"] as Map<String, Object>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to not pull snapshots for production builds, so we need to detect the grails version here.
Replaced by #14686 |
The first time you run
./grails
you may see the following messages if depedencies were cached from a repository other thanmavenCentral()
such asrepo.grails.org
.