Skip to content

Use groovy 4 for grails-gradle-tasks #14759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025
Merged

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented May 20, 2025

Groovy 3 was conflicting with Groovy 4 version used by some other Grails dependencies in the build, such as org.apache.grails:grails-data-hibernate5

Resolves:

A problem occurred configuring root project 'Test8'.
> Could not resolve all artifacts for configuration 'classpath'.
   > Could not resolve org.apache.groovy:groovy:4.0.26.
     Required by:
         root project : > org.apache.grails:grails-bom:7.0.0-SNAPSHOT:20250520.032711-84 > org.apache.groovy:groovy-bom:4.0.26
         root project : > org.apache.grails:grails-bom:7.0.0-SNAPSHOT:20250520.032711-84 > org.apache.grails:grails-spring:7.0.0-SNAPSHOT:20250520.032711-84 > org.apache.groovy:groovy-xml:4.0.26
      > Module 'org.apache.groovy:groovy' has been rejected:
           Cannot select module with conflict on capability 'org.codehaus.groovy:groovy:4.0.26' also provided by [org.codehaus.groovy:groovy:3.0.24(runtime)]
   > Could not resolve org.codehaus.groovy:groovy.
     Required by:
         root project : > org.apache.grails:grails-gradle-plugins:7.0.0-SNAPSHOT:20250520.001817-109 > org.apache.grails:grails-gradle-tasks:7.0.0-SNAPSHOT:20250520.001817-1
      > Module 'org.codehaus.groovy:groovy' has been rejected:
           Cannot select module with conflict on capability 'org.codehaus.groovy:groovy:3.0.24' also provided by [org.apache.groovy:groovy:4.0.26(groovyRuntimeElements)]
> There are 2 more failures with identical causes.

Was conflicting with Groovy 4 version used by some other Grails dependencies in the build
@jamesfredley jamesfredley self-assigned this May 20, 2025
@jamesfredley jamesfredley moved this to In Progress in Apache Grails 7.0.x May 20, 2025
@jamesfredley jamesfredley added this to the grails:7.0.0-M4 milestone May 20, 2025
@jamesfredley jamesfredley requested a review from Copilot May 20, 2025 19:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the groovy dependency to use Groovy 4 for the grails-gradle tasks to resolve conflicts with other Grails dependencies. Key changes include updating the dependency group and version source for Groovy, and removing the exclusion for the Groovy group.

Comments suppressed due to low confidence (1)

grails-gradle/tasks/build.gradle:34

  • Document the removal of the exclusion for org.apache.groovy to clarify that it is now required due to the upgrade to Groovy 4.
exclude group: 'org.apache.groovy'

@apache apache deleted a comment from Copilot AI May 20, 2025
@jamesfredley jamesfredley requested review from jdaugherty and matrei May 20, 2025 19:40
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@jamesfredley jamesfredley merged commit 707ee8b into 7.0.x May 20, 2025
5 checks passed
@jamesfredley jamesfredley deleted the grails-gradle-tasks-groovy-4 branch May 20, 2025 21:54
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache Grails 7.0.x May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants