[#5361] improvment(hadoop-catalog): Introduce a timeout mechanism to get Hadoop File System. #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerryshao |
jerryshao
reviewed
Oct 31, 2024
| .atMost(timeoutSeconds, TimeUnit.SECONDS) | ||
| .until( | ||
| () -> { | ||
| fileSystem.set(provider.getFileSystem(path, config)); |
There was a problem hiding this comment.
Why it is so time-consuming to initialize the filesystem client?
There was a problem hiding this comment.
If the user sets an incorrect endpoint, the client will retry to get the connection for a certain amount of time.
There was a problem hiding this comment.
I don't think you really fix this problem without using another thread to create a FS and polling the status asynchronously?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce a timeout mechanism when getting a Hadoop FileSystem instance.
Why are the changes needed?
Cloud filesystem like S3 and OSS(10 minutes) has a very long connection and can't be tune by configuration, this will cause deadlock as it will hold the tree lock for a long time
Fix: #5361
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Existing test.