[#7552] feat(policy): Add policy entity and POConverters (part-2) #7361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
changed the title
Jackeyzhe
reviewed
Jun 9, 2025
| .withName(policyPO.getPolicyName()) | ||
| .withNamespace(namespace) | ||
| .withType(policyPO.getPolicyType()) | ||
| .withComment(policyPO.getPolicyVersionPO().getPolicyComment()) |
There was a problem hiding this comment.
Do you think it should check if the policyVersion is null here?
There was a problem hiding this comment.
unnecessary, because PolicyPO.Builder already did the validation
|
This PR is too big, can you please split into several small PRs for better review? |
mchades
changed the title
mchades
changed the title
Split done in this PR, plz help to review when you have time, thx! @jerryshao |
mchades
changed the title
jerryshao
reviewed
Jul 7, 2025
jerryshao
requested changes
Jul 7, 2025
core/src/main/java/org/apache/gravitino/policy/CustomPolicy.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/gravitino/storage/relational/po/PolicyPO.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jul 8, 2025
| @@ -112,20 +236,48 @@ public interface Policy extends Auditable { | |||
| * | |||
| * @throws IllegalPolicyException if the policy is not valid. | |||
| */ | |||
| void validate() throws IllegalPolicyException; | |||
| default void validate() throws IllegalPolicyException { | |||
There was a problem hiding this comment.
Who will call this validate() method?
There was a problem hiding this comment.
Currently, it's called by PolicyEntity.valiate()
There was a problem hiding this comment.
I would suggest to move this method to PolicyEntity, this seems is not a user-facing interface, or should user be aware of.
api/src/main/java/org/apache/gravitino/policy/PolicyContent.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jul 9, 2025
api/src/main/java/org/apache/gravitino/policy/PolicyContent.java
Outdated
Show resolved
Hide resolved
jerryshao
approved these changes
Jul 9, 2025
vishnu-chalil
pushed a commit
to vishnu-chalil/gravitino
that referenced
this pull request
Jul 14, 2025
…2) (apache#7361) ### What changes were proposed in this pull request? Add policy entity and POConverters ### Why are the changes needed? Fix: apache#7552 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tests added
hdygxsj
pushed a commit
to hdygxsj/gravitino
that referenced
this pull request
Jul 15, 2025
…2) (apache#7361) ### What changes were proposed in this pull request? Add policy entity and POConverters ### Why are the changes needed? Fix: apache#7552 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tests added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add policy entity and POConverters
Why are the changes needed?
Fix: #7552
Does this PR introduce any user-facing change?
no
How was this patch tested?
tests added