Skip to content

[#7338] feat(trino-connector): Support external type with MySQL #7578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

hqbhoho
Copy link
Contributor

@hqbhoho hqbhoho commented Jul 5, 2025

What changes were proposed in this pull request?

Support MySQL external type with Trino.

Why are the changes needed?

Fix: #7338
Fix: #7339

Does this PR introduce any user-facing change?

no

How was this patch tested?

local integration-test

@hqbhoho hqbhoho marked this pull request as draft July 5, 2025 01:59
@hqbhoho hqbhoho changed the title [#7338] feat(trino-connector): Support external type with MySQL [#7338] feat(trino-connector): Support all type with MySQL Jul 5, 2025
@hqbhoho hqbhoho force-pushed the feature/support_mysql_type branch from 0d67f3d to 397abd7 Compare July 5, 2025 03:41
@hqbhoho hqbhoho changed the title [#7338] feat(trino-connector): Support all type with MySQL [#7338] feat(trino-connector): Support external type with MySQL Jul 5, 2025
@hqbhoho hqbhoho marked this pull request as ready for review July 5, 2025 03:50
@hqbhoho
Copy link
Contributor Author

hqbhoho commented Jul 5, 2025

@diqiu50 @yuqi1129 @mchades Could you PTAL at this PR? Thanks!

I want to add support for ​unsigned numeric types​​ (e.g., FLOAT UNSIGNED,DOUBLE UNSIGNED) in org.apache.gravitino.catalog.mysql.converter.MysqlTypeConverter in another PR.

Currently, ​​only DECIMAL UNSIGNED is implemented​​ with MysqlTypeConverter#toGravitino, which requires precision and scale for conversion​​.

@hqbhoho hqbhoho force-pushed the feature/support_mysql_type branch from 397abd7 to 664059b Compare July 5, 2025 04:12
@hqbhoho hqbhoho force-pushed the feature/support_mysql_type branch from 664059b to c36e16b Compare July 7, 2025 08:18
@hqbhoho hqbhoho requested a review from diqiu50 July 7, 2025 08:20
Copy link
Contributor

@diqiu50 diqiu50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hqbhoho hqbhoho force-pushed the feature/support_mysql_type branch from 9879643 to c4c841d Compare July 9, 2025 10:18
@hqbhoho
Copy link
Contributor Author

hqbhoho commented Jul 9, 2025

@diqiu50 @yuqi1129 I have rebasing on main, Could you merge it if no issues? Thanks!

@yuqi1129 yuqi1129 merged commit 1a20686 into apache:main Jul 9, 2025
30 checks passed
vishnu-chalil pushed a commit to vishnu-chalil/gravitino that referenced this pull request Jul 14, 2025
…apache#7578)

### What changes were proposed in this pull request?
Support MySQL external type with Trino.

### Why are the changes needed?

Fix: apache#7338
Fix: apache#7339

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
local integration-test
hdygxsj pushed a commit to hdygxsj/gravitino that referenced this pull request Jul 15, 2025
…apache#7578)

### What changes were proposed in this pull request?
Support MySQL external type with Trino.

### Why are the changes needed?

Fix: apache#7338
Fix: apache#7339

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
local integration-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants