[#7589] fix (clients): check null before adding request headers in HTTPClient #7601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgereuben
changed the title
|
It looks like the test case you added is failing. Is the test correct? |
Hi @justinmclean, This was due to mock server path collision between testGetSuccess() and testNullHeadersDoNotCauseNPE(). I've changed test data from "test" to "hank" to ensure consistency across all test methods that share the same mock server path (GET_success) |
vishnu-chalil
pushed a commit
to vishnu-chalil/gravitino
that referenced
this pull request
Jul 14, 2025
… in HTTPClient (apache#7601) ### What changes were proposed in this pull request? Added a null check for empty headers before adding request headers in HTTPClient. Closes: [apache#7589](apache#7589) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a unit test.
hdygxsj
pushed a commit
to hdygxsj/gravitino
that referenced
this pull request
Jul 15, 2025
… in HTTPClient (apache#7601) ### What changes were proposed in this pull request? Added a null check for empty headers before adding request headers in HTTPClient. Closes: [apache#7589](apache#7589) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a null check for empty headers before adding request headers in HTTPClient.
Closes: #7589
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a unit test.