[#4755] improvement (trino-connector): Trino connector support the format table properties of Iceberg catalog #7612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
previously approved these changes
Jul 9, 2025
| @@ -16,6 +16,8 @@ CREATE TABLE | |||
| ) | |||
| COMMENT '' | |||
| WITH ( | |||
| format = 'PARQUET', | |||
| format_version = '2', | |||
There was a problem hiding this comment.
Is the value of format_version always '2'? What if Iceberg upgrade the format to 3?
There was a problem hiding this comment.
After the upgrade, it would also be easy to replace this using a script.
| @@ -110,6 +117,14 @@ public GravitinoTable createTable(ConnectorTableMetadata tableMetadata) { | |||
| toGravitinoTableProperties( | |||
| removeKeys(tableMetadata.getProperties(), ICEBERG_PROPERTIES_TO_REMOVE)); | |||
|
|
|||
| if (propertyMap.containsKey(ICEBERG_FORMAT_PROPERTY)) { | |||
| String format = propertyMap.get(ICEBERG_FORMAT_PROPERTY).toString(); | |||
| properties.put(FORMAT, format); | |||
There was a problem hiding this comment.
I wonder if the value of PROVIDER is always not null when the property format is provided.
|
@diqiu50 |
FANNG1
reviewed
Jul 10, 2025
...c/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergMetadataAdapter.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jul 10, 2025
...c/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergMetadataAdapter.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jul 14, 2025
...c/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergMetadataAdapter.java
Show resolved
Hide resolved
|
LGTM except minor comments. |
|
@FANNG1 |
FANNG1
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Trino connector support the format table properties of Iceberg catalog
Why are the changes needed?
Fix: #4755
Does this PR introduce any user-facing change?
No
How was this patch tested?
IT