[#7382] feat(model): Implement operations for model version with multiple URIs #7622
+731
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaozcy
changed the title
|
Hi @xiaozcy this PR is too big to review, I would suggest to split into some small PRs, like moving event related codes to another PR, which will be easy to review. |
|
@jerryshao OK, I'll split it up later. |
|
@jerryshao Please help review #7674 first, I will rebase this branch after it is merged. |
|
Hi @jerryshao, this PR is ready for review, thanks. |
jerryshao
reviewed
Jul 17, 2025
| throw new IllegalArgumentException("URI must not be blank for name: " + name); | ||
| } | ||
| }); | ||
|
|
There was a problem hiding this comment.
I think we should do an such check when we received the request, not postpone to here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR implements operations for model version with multiple URIs.
Why are the changes needed?
Fix: #7382
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.