-
Notifications
You must be signed in to change notification settings - Fork 1.9k
remove excess manifest attributes #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This is also a work-in-progress for dropping |
build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy
Outdated
Show resolved
Hide resolved
Saw this after my previous comment. Yes, if we can really remove Created-By and Ant-Version, that would be great and remove the need for the hard-coded value for Created-By. |
I merged in the "pre-work" and minor refactoring. Do you want to rebase this against master? Should reduce to just a few lines. |
I have rebased, added comments to the I still think all 3 can go, but the urgency is not that great. Just a note, I tried |
I suspect not all of these are still required. This is a draft to explore removing all or some. And for any kept, adding some docs and tests.
Ant-Version
Bundle-ClassPath
Created-By
DynamicImport-Package
Eclipse-BuddyPolicy
Eclipse-ExtensibleAPI
Extension-Name
Tool