Skip to content

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Oct 8, 2025

Description of PR

JIRA: YARN-11877. Resolve JAXB IllegalAnnotation issue in TimelineEntity with Jersey 2.x.

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@abstractdog
Copy link

abstractdog commented Oct 8, 2025

thanks @slfan1989 for this effort, it means a lot to the Tez project!
I believe "Tez" related stuff cannot stay in the hadoop repository, so if you think the unit test provided makes sense, you can adapt it to a generic one

also double-checked that adding TimelineEntityWriter by config.register makes the unit test work, however, to stay consistent, implementing the TimelineEntityReader also makes sense

@slfan1989
Copy link
Contributor Author

thanks @slfan1989 for this effort, it means a lot to the Tez project! I believe "Tez" related stuff cannot stay in the hadoop repository, so if you think the unit test provided makes sense, you can adapt it to a generic one

also double-checked that adding TimelineEntityWriter by config.register makes the unit test work, however, to stay consistent, implementing the TimelineEntityReader also makes sense

@abstractdog Thank you for the information! I will record you as a co-author of this PR. My understanding of the timeline might not be fully comprehensive. During the upgrade of Jersey to version 2.x, my primary focus was on adapting the unit tests bundled with the Hadoop project. Please feel free to share any additional feedback or details. I will continue to follow up on issues related to Jersey 2.x.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 7m 30s Maven dependency ordering for branch
+1 💚 mvninstall 27m 5s trunk passed
+1 💚 compile 3m 5s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 2m 46s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 0m 47s trunk passed
+1 💚 mvnsite 0m 57s trunk passed
+1 💚 javadoc 0m 56s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 53s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 1m 56s trunk passed
+1 💚 shadedclient 24m 21s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 mvninstall 0m 35s the patch passed
+1 💚 compile 2m 44s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 2m 44s the patch passed
+1 💚 compile 2m 50s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 2m 50s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 47s /results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt hadoop-yarn-project/hadoop-yarn: The patch generated 72 new + 14 unchanged - 0 fixed = 86 total (was 14)
+1 💚 mvnsite 0m 54s the patch passed
+1 💚 javadoc 0m 44s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 44s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 4s the patch passed
+1 💚 shadedclient 23m 35s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 37s hadoop-yarn-api in the patch passed.
+1 💚 unit 3m 21s hadoop-yarn-server-applicationhistoryservice in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
113m 4s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8018/1/artifact/out/Dockerfile
GITHUB PR #8018
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux b3eaad732b10 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6996edf
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8018/1/testReport/
Max. process+thread count 546 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8018/1/console
versions git=2.25.1 maven=3.9.11 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 8m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 9m 9s Maven dependency ordering for branch
+1 💚 mvninstall 16m 34s trunk passed
+1 💚 compile 2m 56s trunk passed
+1 💚 checkstyle 0m 46s trunk passed
+1 💚 mvnsite 0m 56s trunk passed
+1 💚 javadoc 0m 55s trunk passed
-1 ❌ spotbugs 0m 38s /branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt hadoop-yarn-api in trunk failed.
-1 ❌ spotbugs 0m 26s /branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-applicationhistoryservice in trunk failed.
+1 💚 shadedclient 18m 4s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 0m 39s the patch passed
+1 💚 compile 2m 40s the patch passed
+1 💚 javac 2m 40s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 43s /results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt hadoop-yarn-project/hadoop-yarn: The patch generated 72 new + 14 unchanged - 0 fixed = 86 total (was 14)
+1 💚 mvnsite 0m 53s the patch passed
+1 💚 javadoc 0m 46s the patch passed
-1 ❌ spotbugs 0m 33s /patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt hadoop-yarn-api in the patch failed.
-1 ❌ spotbugs 0m 23s /patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-applicationhistoryservice in the patch failed.
+1 💚 shadedclient 18m 49s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 37s hadoop-yarn-api in the patch passed.
+1 💚 unit 2m 52s hadoop-yarn-server-applicationhistoryservice in the patch passed.
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
82m 24s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8018/2/artifact/out/Dockerfile
GITHUB PR #8018
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 9692615874f6 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 5dc8c20
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8018/2/testReport/
Max. process+thread count 728 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8018/2/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@github-actions github-actions bot added the build label Oct 12, 2025
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 11m 33s Maven dependency ordering for branch
+1 💚 mvninstall 15m 40s trunk passed
+1 💚 compile 8m 23s trunk passed
+1 💚 checkstyle 1m 38s trunk passed
-1 ❌ mvnsite 7m 6s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 javadoc 4m 54s trunk passed
-1 ❌ spotbugs 0m 29s /branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt hadoop-yarn-api in trunk failed.
-1 ❌ spotbugs 0m 21s /branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-applicationhistoryservice in trunk failed.
-1 ❌ spotbugs 0m 16s /branch-spotbugs-root.txt root in trunk failed.
+1 💚 shadedclient 28m 53s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 15m 28s the patch passed
+1 💚 compile 8m 12s the patch passed
+1 💚 javac 8m 12s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 31s /results-checkstyle-root.txt root: The patch generated 72 new + 14 unchanged - 0 fixed = 86 total (was 14)
-1 ❌ mvnsite 3m 39s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 javadoc 4m 51s the patch passed
+1 💚 spotbugs 19m 24s the patch passed
+1 💚 shadedclient 30m 42s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 586m 19s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 0m 50s The patch does not generate ASF License warnings.
721m 52s
Reason Tests
Failed junit tests hadoop.fs.tosfs.object.TestObjectOutputStream
hadoop.fs.tosfs.object.tos.auth.TestEnvironmentCredentialsProvider
hadoop.fs.tosfs.commit.TestMagicOutputStream
hadoop.fs.tosfs.object.TestObjectRangeInputStream
hadoop.fs.tosfs.object.tos.auth.TestDefaultCredentialsProviderChain
hadoop.fs.tosfs.object.TestObjectMultiRangeInputStream
hadoop.yarn.server.router.subcluster.fair.TestYarnFederationWithFairScheduler
hadoop.yarn.sls.appmaster.TestAMSimulator
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8018/3/artifact/out/Dockerfile
GITHUB PR #8018
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux ca0bd07bdb06 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 440ab72
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8018/3/testReport/
Max. process+thread count 5075 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8018/3/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants