HADOOP-19638. [Addendum] [JDK17] Set Up CI Support JDK17.#8030
Merged
slfan1989 merged 3 commits intoapache:trunkfrom Oct 16, 2025
Merged
HADOOP-19638. [Addendum] [JDK17] Set Up CI Support JDK17.#8030slfan1989 merged 3 commits intoapache:trunkfrom
slfan1989 merged 3 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
Contributor
Author
|
@steveloughran Could you please review this PR? Thank you very much! |
Contributor
Author
|
@Hexiaoqiao Could you please review this PR? Thank you very much! |
szetszwo
reviewed
Oct 15, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@slfan1989 , thanks for working on this! Just have a question inlined.
| YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-17-openjdk-amd64") | ||
| # test with Java 17 & Java 21 | ||
| YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-17-openjdk-amd64") | ||
| YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-21-openjdk-amd64") |
Contributor
There was a problem hiding this comment.
Do we need two jdk dirs?
--multijdkdirs=/usr/lib/jvm/java-21-openjdk-amd64,/usr/lib/jvm/java-17-openjdk-amd64
https://yetus.apache.org/documentation/0.15.1/precommit/usage-intro/#multijdk
Contributor
Author
There was a problem hiding this comment.
Thank you very much for helping with the review! Since I’m not yet very familiar with Yetus, the current configuration was created by referring to and simulating the original JDK 8 and JDK 11 configurations.
# test with Java 8 and 11
YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8-openjdk-amd64")
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-11-openjdk-amd64")
YETUS_ARGS+=("--multijdktests=compile")
Contributor
There was a problem hiding this comment.
I see. Let's keep using it then.
szetszwo
approved these changes
Oct 15, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
| YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-17-openjdk-amd64") | ||
| # test with Java 17 & Java 21 | ||
| YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-17-openjdk-amd64") | ||
| YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-21-openjdk-amd64") |
Contributor
There was a problem hiding this comment.
I see. Let's keep using it then.
Hexiaoqiao
approved these changes
Oct 16, 2025
Contributor
Hexiaoqiao
left a comment
Hexiaoqiao
left a comment
There was a problem hiding this comment.
LGTM. +1 from my side.
Contributor
Author
|
@szetszwo @Hexiaoqiao @zhtttylz Thank you very much for reviewing the code! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-19638. [Addendum] [JDK17] Set Up CI Support JDK17.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?