Skip to content

HBASE-29325 Gson reflection failures on TestBucketCache.testCacheSimple #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchevreuil merged 6 commits into from
Jul 7, 2025
Merged

HBASE-29325 Gson reflection failures on TestBucketCache.testCacheSimple #6999

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27c6ca7
HBASE-29325 Gson reflection failures on TestBucketCache.testCacheSimple
wchevreuil May 19, 2025
fd495a1
spotless
wchevreuil May 22, 2025
22f492e
removing filtering of static and transient
wchevreuil May 28, 2025
bbbf567
removing commented code
wchevreuil May 28, 2025
6de891d
moving the private field exclusions to the block cache gson instance …
wchevreuil Jul 1, 2025
ac872b0
spotless
wchevreuil Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 25 additions & 23 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import static org.apache.hadoop.hbase.io.hfile.HFileBlock.FILL_HEADER;

import java.io.IOException;
import java.lang.reflect.Modifier;
import java.nio.ByteBuffer;
import java.util.HashSet;
import java.util.Map;
Expand Down Expand Up @@ -58,29 +59,30 @@ public class BlockCacheUtil {
/**
* Needed generating JSON.
*/
private static final Gson GSON = GsonUtil.createGson()
.registerTypeAdapter(FastLongHistogram.class, new TypeAdapter<FastLongHistogram>() {

@Override
public void write(JsonWriter out, FastLongHistogram value) throws IOException {
AgeSnapshot snapshot = new AgeSnapshot(value);
out.beginObject();
out.name("mean").value(snapshot.getMean());
out.name("min").value(snapshot.getMin());
out.name("max").value(snapshot.getMax());
out.name("75thPercentile").value(snapshot.get75thPercentile());
out.name("95thPercentile").value(snapshot.get95thPercentile());
out.name("98thPercentile").value(snapshot.get98thPercentile());
out.name("99thPercentile").value(snapshot.get99thPercentile());
out.name("999thPercentile").value(snapshot.get999thPercentile());
out.endObject();
}

@Override
public FastLongHistogram read(JsonReader in) throws IOException {
throw new UnsupportedOperationException();
}
}).setPrettyPrinting().create();
private static final Gson GSON =
GsonUtil.createGson().excludeFieldsWithModifiers(Modifier.PRIVATE)
.registerTypeAdapter(FastLongHistogram.class, new TypeAdapter<FastLongHistogram>() {

@Override
public void write(JsonWriter out, FastLongHistogram value) throws IOException {
AgeSnapshot snapshot = new AgeSnapshot(value);
out.beginObject();
out.name("mean").value(snapshot.getMean());
out.name("min").value(snapshot.getMin());
out.name("max").value(snapshot.getMax());
out.name("75thPercentile").value(snapshot.get75thPercentile());
out.name("95thPercentile").value(snapshot.get95thPercentile());
out.name("98thPercentile").value(snapshot.get98thPercentile());
out.name("99thPercentile").value(snapshot.get99thPercentile());
out.name("999thPercentile").value(snapshot.get999thPercentile());
out.endObject();
}

@Override
public FastLongHistogram read(JsonReader in) throws IOException {
throw new UnsupportedOperationException();
}
}).setPrettyPrinting().create();

/** Returns The block content as String. */
public static String toString(final CachedBlock cb, final long now) {
Expand Down