HBASE-29378 Make TestingHBaseCluster expose address/port information #7074
+120
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Apache9
approved these changes
Jun 6, 2025
NihalJain
approved these changes
Jun 6, 2025
junegunn
commented
Jun 6, 2025
hbase-testing-util/src/main/java/org/apache/hadoop/hbase/testing/TestingHBaseClusterImpl.java
Outdated
Show resolved
Hide resolved
junegunn
commented
Jun 6, 2025
hbase-testing-util/src/main/java/org/apache/hadoop/hbase/testing/TestingHBaseClusterImpl.java
Outdated
Show resolved
Hide resolved
junegunn
commented
Jun 6, 2025
Comment on lines
239
to
243
| @Override | ||
| public Optional<Integer> getActiveZooKeeperClientPort() { | ||
| return Optional.ofNullable(util.getZkCluster()).map(MiniZooKeeperCluster::getClientPort) | ||
| .filter(port -> port > 0); | ||
| } |
There was a problem hiding this comment.
Actually, I have a second thought here as well.
Since the port is going to be used to build hbase.zookeeper.quorum, we should probably return the ports of all servers, not just the leader's.
There was a problem hiding this comment.
Just return the zookeeper connect string?
There was a problem hiding this comment.
So you're saying one can directly use the return value as hbase.zookeeper.quorum? (e.g. localhost:1111,localhost:2222,localhost:3333). If that's the case, I agree. I don't see much value in returning the ports separately and forcing the user to assemble the configuration string themselves.
|
Please take a look at the updated methods in 86ca728.
With the updated method signatures, it's going to be easier for users to print the information they need. println("hbase.zookeeper.quorum: ${cluster.zooKeeperQuorum.orElse("N/A")}")
println("hbase.masters: ${cluster.masterAddresses.joinToString(",")}")
println("Active HBase Master: ${cluster.activeMasterInfoAddress.orElse("N/A")}")
println("Active HDFS NameNode: ${cluster.activeNameNodeInfoAddress.orElse("N/A")}")It's quite different from what I originally proposed. If you like it, I'll update the Jira description accordingly. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-29378